review: #84 comments from PR review

atorus-research · Jun 14, 2023 · a81cf50 · a81cf50
1 parent fcd5337
commit a81cf50
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -82,4 +82,4 @@ Suggests:
 Config/testthat/edition: 3
 VignetteBuilder: knitr
 Depends: 
- R (>= 2.10)
+ R (>= 3.5)
diff --git a/man/length_log.Rd b/man/length_log.Rd
diff --git a/vignettes/deepdive.Rmd b/vignettes/deepdive.Rmd
@@ -165,7 +165,7 @@ adsl %>%
 
 For the next six sections, we are going to explore the Warnings and Errors messages generated by the `{xportr}` core functions. To better explore these, we will either manipulate the ADaM dataset or specification file to help showcase the ability of the `{xportr}` functions to detect issues. 
 
-**NOTE:** We have made the ADSL, `adsl`, and Specification File, `var_spec`, available in this package. Users can find additional datasets and specification files on our [repo](https://github.com/atorus-research/xportr) in the `example_data_specs` folder. We have not included these in our package to help keep the package to a minimum size.  
+**NOTE:** We have made the ADSL, `xportr::adsl`, and Specification File, `xportr::var_spec`, available in this package. Users can find additional datasets and specification files on our [repo](https://github.com/atorus-research/xportr) in the `example_data_specs` folder. 
 
 ### Setting up our metadata object