lintr: revert to disable object_usage

atorus-research · Feb 29, 2024 · ba5b9ef · ba5b9ef
1 parent b7c294b
commit ba5b9ef
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/.lintr b/.lintr
@@ -1,5 +1,6 @@
 linters: linters_with_defaults(
   line_length_linter(120),
+  object_usage linter = NULL,
   object_name_linter = object_name_linter(
     styles = c("snake_case", "symbols"),
     regexes = c(

diff --git a/R/messages.R b/R/messages.R
@@ -43,8 +43,8 @@ var_names_log <- function(tidy_names_df, verbose) {
     )
 
   # Message regarding number of variables that were renamed/ modified
-  num_renamed <- nrow(only_renames) # nolint: object_usage.
-  tot_num_vars <- nrow(tidy_names_df) # nolint: object_usage.
+  num_renamed <- nrow(only_renames)
+  tot_num_vars <- nrow(tidy_names_df)
 
   cli_h2(glue(
     .sep = " ",

diff --git a/R/utils-xportr.R b/R/utils-xportr.R
@@ -77,7 +77,7 @@ encode_vals <- function(x) {
 #' @return String of text to append error message
 #' @noRd
 fmt_vars <- function(x) {
-  vars <- ntext(length(x), "Variable", "Variables") # nolint: object_usage.
+  vars <- ntext(length(x), "Variable", "Variables")
   glue("{vars} {encode_vars(x)}")
 }
 
@@ -88,8 +88,8 @@ fmt_vars <- function(x) {
 #' @return String of text to append error message
 #' @noRd
 fmt_labs <- function(x) {
-  labs <- ntext(length(x), "Label", "Labels") # nolint: object_usage.
-  val <- paste0(names(x), "=", unname(x)) # nolint: object_usage.
+  labs <- ntext(length(x), "Label", "Labels")
+  val <- paste0(names(x), "=", unname(x))
   glue("{labs} {encode_vals(val)}")
 }
 
@@ -100,7 +100,7 @@ fmt_labs <- function(x) {
 #' @return String of text to append error message
 #' @noRd
 fmt_fmts <- function(x) {
-  fmts <- ntext(length(x), "Format", "Formats") # nolint: object_usage.
+  fmts <- ntext(length(x), "Format", "Formats")
   glue("{fmts} {encode_vals(x)}")
 }
 
@@ -415,7 +415,7 @@ check_metadata <- function(metadata, include_fun_message, null.ok = FALSE) { # n
     return(TRUE)
   }
 
-  extra_string <- ", 'Metacore' or set via 'xportr_metadata()'" # nolint: object_usage.
+  extra_string <- ", 'Metacore' or set via 'xportr_metadata()'"
   if (!include_fun_message) {
     extra_string <- " or 'Metacore'"
   }