-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #84 xportr deep dive vignette #141
Conversation
Merge remote-tracking branch 'origin/devel' into 84_xportr_deep_dive_vignette # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Merge remote-tracking branch 'origin/devel' into 84_xportr_deep_dive_vignette # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…t label function Merge remote-tracking branch 'origin/122_update_pkgdown' into 84_xportr_deep_dive_vignette # Conflicts: # _pkgdown.yml
Merge remote-tracking branch 'origin/44-pipe-metadata' into 84_xportr_deep_dive_vignette # Conflicts: # NEWS.md
Merge remote-tracking branch 'origin/devel' into 84_xportr_deep_dive_vignette # Conflicts: # docs/404.html # docs/LICENSE-text.html # docs/LICENSE.html # docs/authors.html # docs/index.html # docs/pkgdown.yml
Styling linting
…ta' into 84_xportr_deep_dive_vignette
Remove extra metadata file
…ning and errors for deepdive. Merge remote-tracking branch 'origin/devel' into 84_xportr_deep_dive_vignette # Conflicts: # man/figures/design_flow.png
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
…rus-research/xportr into 84_xportr_deep_dive_vignette
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
…rus-research/xportr into 84_xportr_deep_dive_vignette
…rus-research/xportr into 84_xportr_deep_dive_vignette
Hi all Updated website: https://bms63.github.io/xportr/ Will fix failing actions tmr. Think we are close - still couple of minor issues to iron with formats, but that might be for next release. |
@bms63 and all, Made a bunch of suggestions for datatables in a separate PR that merges to this one, check it out Changes:
|
@atorus-research/xportr-development-team - whew!! this was a big one. TY for all the reviews and code suggestions. I think this one is good to go now. Unless folks want to take a final peak https://bms63.github.io/xportr/index.html. I think it will be good to see my version of the website published with the docs updates coming from #148 as well |
…rus-research/xportr into 84_xportr_deep_dive_vignette
Thank you for your Pull Request!
We have developed a Pull Request template to aid you and our reviewers. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the xportr codebase remains robust and consistent.
The scope of
{xportr}
{xportr}
's scope is to enable R users to write out submission compliantxpt
files that can be delivered to a Health Authority or to downstream validation software programs. We see labels, lengths, types, ordering and formats from a dataset specification object (SDTM and ADaM) as being our primary focus. We also see messaging and warnings to users around applying information from the specification file as a primary focus. Please make sure your Pull Request meets this scope of {xportr}. If your Pull Request moves beyond this scope, please get in touch with the{xportr}
team on slack or create an issue to discuss.Please check off each task box as an acknowledgment that you completed the task. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.Changes Description
Vignette can be found here: https://bms63.github.io/xportr/articles/deepdive.html
Task List
devel
branch, Pull Requests tomain
should use the Release Pull Request Templatestyler
package and functions to style files accordingly.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelypkgdown::build_site()
and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.