Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function Documentation ReDo #148
Function Documentation ReDo #148
Changes from all commits
d3bde36
63fc2a5
dd81155
a6ada3b
3db5abc
2c3a47f
04a45c1
e27d2df
e340e56
7756a7a
9155127
39679c8
207c592
b0874df
669e0e6
ebf91e5
231e959
e41fe46
27c495e
cb99624
acc4b8d
3625e5f
c8e6113
4dd07c9
c339d5e
c676711
334d2f6
7a168d6
0e82d92
3417232
7ad340b
b7aaa9f
55a3e20
0014120
af7f6d2
985932a
d8e563c
0987a2f
35226d7
ce91175
5630317
191c885
3fca4a5
3d7bd42
09d4474
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not that messaging is currently not available for this function??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the lack of 'verbose' argument and no messaging section notes that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Column should be correct here. Dataframe labels are assigned with
xportr_df_label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get an example of greater than 40 label or missing label with verbose = warn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be too verbose for function documentation and would be a good example in the deep-dive vigentte
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to internally link the Messaging and Metadata sections? @vedhav or @averissimo any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sections' text of "Metadata" and "Messaging" seem pretty unique to each function.
If they were common, then we could do that
The parameters are already inherited (which has a common description). Not in
xportr_length
, but others inherit from this oneThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also create simple examples that use
verbose = "warn"
in each of our core functions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is too verbose for function documentation and is a good example for vignettes and the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha!! good point