Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #221 Removes suggested packages and update CI actions #229

Merged
merged 46 commits into from
Feb 14, 2024

Conversation

averissimo
Copy link
Collaborator

@averissimo averissimo commented Jan 30, 2024

Changes Description

  • Removed dependencies from DESCRIPTION
  • Removed SASxport installation in CI
  • Adds items to wordlist (spelling action doesn't pass without 😄)
  • Using same CI/CD infrastructure as Admiral
    • Except for R CMD check to test multiple platforms and R versions

Task List

  • The spirit of xportr is met in your Pull Request
  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Summary of changes filled out in the above Changes Description. Can be removed or left blank if changes are minor/self-explanatory.
  • Code is formatted according to the tidyverse style guide. Use styler package and functions to style files accordingly.
  • Updated relevant unit tests or have written new unit tests. See our Wiki for conventions used in this package.
  • Creation/updated relevant roxygen headers and examples. See our Wiki for conventions used in this package.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Make sure that the package version in the NEWS.md and DESCRIPTION file is same. Don't worry about updating the version because it will be auto-updated using the vbump.yaml CI.
  • Address any updates needed for vignettes and/or templates
  • Link the issue Development Panel so that it closes after successful merging.
  • Fix merge conflicts
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37c520e) 100.00% compared to head (7a25c3a) 100.00%.
Report is 2 commits behind head on main.

❗ Current head 7a25c3a differs from pull request most recent head 0bea653. Consider uploading reports for the commit 0bea653 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #229   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          665       626   -39     
=========================================
- Hits           665       626   -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@averissimo
Copy link
Collaborator Author

It's difficult to test this, so I've added a commit that will fail the tests.

Feel free to add and remove commits to test PR

  • 7455486 passes CI (excluding links)
  • 40d4e80 (fails spelling / linter / styling CI)
  • a649c19 (back to passing tests)

.github/workflows/check-links.yml Outdated Show resolved Hide resolved
.github/workflows/check-links.yml Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
.github/workflows/spellcheck.yml Outdated Show resolved Hide resolved
DESCRIPTION Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 6, 2024

Code Coverage

Package Line Rate Health
xportr 100%
Summary 100% (690 / 690)

.github/workflows/common.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @averissimo just checking on decisions with this PR - do you need any other help or resolutions?

@averissimo
Copy link
Collaborator Author

Kept our CMD workflow as it allows for multiple platforms.

And it's a better test than insightsengineer custom docker environment

@bms63
Copy link
Collaborator

bms63 commented Feb 14, 2024

LGTM! many thanks again!!

@bms63 bms63 merged commit b13dada into main Feb 14, 2024
15 checks passed
@bms63 bms63 deleted the 221-dependency-cleanup branch February 14, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Q: Can all or any of the Suggested packages be removed?
3 participants