-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #221 Removes suggested packages and update CI actions #229
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 665 626 -39
=========================================
- Hits 665 626 -39 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @averissimo just checking on decisions with this PR - do you need any other help or resolutions?
Kept our CMD workflow as it allows for multiple platforms. And it's a better test than insightsengineer custom docker environment |
LGTM! many thanks again!! |
Changes Description
DESCRIPTION
SASxport
installation in CIspelling
action doesn't pass without 😄)R CMD check
to test multiple platforms and R versionsTask List
styler
package and functions to style files accordingly.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelypkgdown::build_site()
and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.vbump.yaml
CI.