Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #183 Add xportr_split Functionality #235

Merged
merged 14 commits into from
Feb 26, 2024
Merged

Closes #183 Add xportr_split Functionality #235

merged 14 commits into from
Feb 26, 2024

Conversation

elimillera
Copy link
Member

@elimillera elimillera commented Feb 12, 2024

Thank you for your Pull Request!

We have developed a Pull Request template to aid you and our reviewers. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the xportr codebase remains robust and consistent.

The scope of {xportr}

{xportr}'s scope is to enable R users to write out submission compliant xpt files that can be delivered to a Health Authority or to downstream validation software programs. We see labels, lengths, types, ordering and formats from a dataset specification object (SDTM and ADaM) as being our primary focus. We also see messaging and warnings to users around applying information from the specification file as a primary focus. Please make sure your Pull Request meets this scope of {xportr}. If your Pull Request moves beyond this scope, please get in touch with the {xportr} team on slack or create an issue to discuss.

Please check off each task box as an acknowledgment that you completed the task. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

Changes Description

Add xportr_split to split datasets during writing based on #183

This closes #183

Task List

  • The spirit of xportr is met in your Pull Request
  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Summary of changes filled out in the above Changes Description. Can be removed or left blank if changes are minor/self-explanatory.
  • Code is formatted according to the tidyverse style guide. Use styler package and functions to style files accordingly.
  • New functions or arguments follow established convention found in the Wiki.
  • Updated relevant unit tests or have written new unit tests. See our Wiki for conventions used in this package.
  • Creation/updated relevant roxygen headers and examples. See our Wiki for conventions used in this package.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • The NEWS.md entry should go under the # xportr development version section. Don't worry about updating the version because it will be auto-updated using the vbump.yaml CI.
  • Address any updates needed for vignettes and/or templates.
  • Link the issue Development Panel so that it closes after successful merging.
  • The developer is responsible for fixing merge conflicts not the Reviewer.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (37c520e) to head (c888563).
Report is 97 commits behind head on main.

❗ Current head c888563 differs from pull request most recent head 1b25231. Consider uploading reports for the commit 1b25231 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #235   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        15    +1     
  Lines          665       687   +22     
=========================================
+ Hits           665       687   +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elimillera is this ready to review?

@elimillera elimillera changed the title Add `xportr_xp Add xportr_split Functionality Feb 13, 2024
R/split.R Outdated Show resolved Hide resolved
R/split.R Outdated Show resolved Hide resolved
R/write.R Outdated Show resolved Hide resolved
R/write.R Show resolved Hide resolved
Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Just a couple of documentation spots and a question on the tests.

@bms63
Copy link
Collaborator

bms63 commented Feb 23, 2024

oh - i guess it doesn't like somethign as all the tests are failing 😱

elimillera and others added 5 commits February 23, 2024 16:16
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
@elimillera
Copy link
Member Author

A couple merge issues and some stuff snuck into main. Should be good to go now

R/split.R Outdated Show resolved Hide resolved
@bms63
Copy link
Collaborator

bms63 commented Feb 26, 2024

@elimillera fantastic work!! Let's see what the roche folks say!!

@rossfarrugia who should we ask to test this out - it is not for the faint-hearted!!

@bms63 bms63 changed the title Add xportr_split Functionality Closes #183 Add xportr_split Functionality Feb 26, 2024
@bms63 bms63 merged commit 63c52b1 into main Feb 26, 2024
15 checks passed
@bms63 bms63 deleted the 183_split_df branch February 26, 2024 21:09
@rossfarrugia
Copy link

@rossfarrugia who should we ask to test this out - it is not for the faint-hearted!!

I'll find some folks. I assume we should just install the latest package from GH main branch right?

@bms63
Copy link
Collaborator

bms63 commented Mar 1, 2024

@rossfarrugia who should we ask to test this out - it is not for the faint-hearted!!

I'll find some folks. I assume we should just install the latest package from GH main branch right?

yes main branch - can use https://atorus-research.github.io/xportr/dev/ to get latest dev version of website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: FDA expectations around minimising xpt filesizes
3 participants