-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #206 Add agency standards vignette #236
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 665 665
=========================================
Hits 665 665 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be awesome!! Just pulling in a few random resources if you haven't stumbled upon them already
https://www.pharmasug.org/proceedings/2021/SS/PharmaSUG-2021-SS-137.pdf
https://www.pharmasug.org/proceedings/2021/EP/PharmaSUG-2021-EP-070.pdf
https://www.lexjansen.com/phuse-us/2019/sa/SA04.pdf
I will track some more down - it also might be a good call out to the slack channel for resources.
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we replace ? with "Information has not yet been collected."
I just replaced all the nine instances of them in the commit 1b22b33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol i was about to add a comment on the News.md and you just did it!!
This looks awesome!! Very excited for this to grow.
Just a few cosmetics things to fix up and then please merge in. |
I applied all your changes, Is there anything else you'd like to change or is it ready to merge? |
LGTM!! |
Closes #206
Changes Description
Adds a vignette showing the standards followed in different agencies
Task List
styler
package and functions to style files accordingly.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelypkgdown::build_site()
and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.NEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)NEWS.md
entry should go under the# xportr development version
section. Don't worry about updating the version because it will be auto-updated using thevbump.yaml
CI.