Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #206 Add agency standards vignette #236

Merged
merged 8 commits into from
Mar 7, 2024

Conversation

vedhav
Copy link
Collaborator

@vedhav vedhav commented Feb 13, 2024

Closes #206

Changes Description

Adds a vignette showing the standards followed in different agencies

Task List

  • The spirit of xportr is met in your Pull Request
  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Summary of changes filled out in the above Changes Description. Can be removed or left blank if changes are minor/self-explanatory.
  • Code is formatted according to the tidyverse style guide. Use styler package and functions to style files accordingly.
  • New functions or arguments follow established convention found in the Wiki.
  • Updated relevant unit tests or have written new unit tests. See our Wiki for conventions used in this package.
  • Creation/updated relevant roxygen headers and examples. See our Wiki for conventions used in this package.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • The NEWS.md entry should go under the # xportr development version section. Don't worry about updating the version because it will be auto-updated using the vbump.yaml CI.
  • Address any updates needed for vignettes and/or templates.
  • Link the issue Development Panel so that it closes after successful merging.
  • The developer is responsible for fixing merge conflicts not the Reviewer.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@vedhav vedhav added the documentation Improvements or additions to documentation label Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (37c520e) to head (6fb52f4).
Report is 107 commits behind head on main.

❗ Current head 6fb52f4 differs from pull request most recent head 1b22b33. Consider uploading reports for the commit 1b22b33 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #236   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          665       665           
=========================================
  Hits           665       665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be awesome!! Just pulling in a few random resources if you haven't stumbled upon them already

https://www.pharmasug.org/proceedings/2021/SS/PharmaSUG-2021-SS-137.pdf
https://www.pharmasug.org/proceedings/2021/EP/PharmaSUG-2021-EP-070.pdf
https://www.lexjansen.com/phuse-us/2019/sa/SA04.pdf

I will track some more down - it also might be a good call out to the slack channel for resources.

@vedhav vedhav changed the title Ddd agency standards vignette Add agency standards vignette Feb 14, 2024
@vedhav vedhav marked this pull request as ready for review March 5, 2024 16:15
vedhav and others added 2 commits March 7, 2024 06:49
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Copy link

github-actions bot commented Mar 7, 2024

Code Coverage

Package Line Rate Health
xportr 100%
Summary 100% (785 / 785)

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace ? with "Information has not yet been collected."

@vedhav
Copy link
Collaborator Author

vedhav commented Mar 7, 2024

Can we replace ? with "Information has not yet been collected."

I just replaced all the nine instances of them in the commit 1b22b33

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol i was about to add a comment on the News.md and you just did it!!

This looks awesome!! Very excited for this to grow.

@bms63
Copy link
Collaborator

bms63 commented Mar 7, 2024

Just a few cosmetics things to fix up and then please merge in.

@bms63 bms63 changed the title Add agency standards vignette Closes #206 Add agency standards vignette Mar 7, 2024
@vedhav
Copy link
Collaborator Author

vedhav commented Mar 7, 2024

Just a few cosmetics things to fix up and then please merge in.

I applied all your changes, Is there anything else you'd like to change or is it ready to merge?

@bms63
Copy link
Collaborator

bms63 commented Mar 7, 2024

Just a few cosmetics things to fix up and then please merge in.

I applied all your changes, Is there anything else you'd like to change or is it ready to merge?

LGTM!!

@vedhav vedhav merged commit c56381f into main Mar 7, 2024
14 of 15 checks passed
@vedhav vedhav deleted the 206-add-agency-standards-vignette branch March 7, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summary of Differences for Regulatory Agencies
2 participants