Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add website to DESCRIPTION #246

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Add website to DESCRIPTION #246

merged 1 commit into from
Feb 22, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Feb 21, 2024

Changes Description

Add website to DESCRIPTION to improve discoverability from CRAN https://blog.r-hub.io/2019/12/10/urls/. Minimal change.

Task List

  • The spirit of xportr is met in your Pull Request
  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Summary of changes filled out in the above Changes Description. Can be removed or left blank if changes are minor/self-explanatory.
  • Code is formatted according to the tidyverse style guide. Use styler package and functions to style files accordingly.
  • New functions or arguments follow established convention found in the Wiki.
  • Updated relevant unit tests or have written new unit tests. See our Wiki for conventions used in this package.
  • Creation/updated relevant roxygen headers and examples. See our Wiki for conventions used in this package.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • The NEWS.md entry should go under the # xportr development version section. Don't worry about updating the version because it will be auto-updated using the vbump.yaml CI.
  • Address any updates needed for vignettes and/or templates.
  • Link the issue Development Panel so that it closes after successful merging.
  • The developer is responsible for fixing merge conflicts not the Reviewer.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@bms63
Copy link
Collaborator

bms63 commented Feb 22, 2024

many thanks @olivroy ! are you an xpt fan? want to join the team for the next release 0.5? Probably in 6-12 months when we re-group.

Join our slack channel if you are interested. https://pharmaverse.slack.com/archives/C02KZQJ3K70

@bms63 bms63 merged commit 358c0f9 into atorus-research:main Feb 22, 2024
15 checks passed
@olivroy olivroy deleted the patch-1 branch February 22, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants