Closes #215, #222: add xportr() and more details about length to deepdive
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 5, 2024
bms63
reviewed
Mar 7, 2024
Comment on lines
+310
to
+318
| There are two sources of length (data-driven and spec-driven): | ||
|
|
||
| - Data-driven length: max length for character columns and 8 for other data types | ||
|
|
||
| - Spec-driven length: from the metadata | ||
|
|
||
| 1. Users can either specify the length in the metadata or leave it blank for data-driven length. | ||
| 2. When the length is missing in the metadata, the data-driven length will be applied. | ||
|
|
bms63
reviewed
Mar 7, 2024
| @@ -479,6 +488,31 @@ ADSL %>% | |||
| xportr_write(path = "adsl.xpt", strict_checks = TRUE) | |||
| ``` | |||
|
|
|||
| ## `xportr()` | |||
There was a problem hiding this comment.
Suggested change
| ## `xportr()` | |
| ## `xportr()` your life? |
maybe... :)
bms63
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your Pull Request!
We have developed a Pull Request template to aid you and our reviewers. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the xportr codebase remains robust and consistent.
The scope of
{xportr}{xportr}'s scope is to enable R users to write out submission compliantxptfiles that can be delivered to a Health Authority or to downstream validation software programs. We see labels, lengths, types, ordering and formats from a dataset specification object (SDTM and ADaM) as being our primary focus. We also see messaging and warnings to users around applying information from the specification file as a primary focus. Please make sure your Pull Request meets this scope of {xportr}. If your Pull Request moves beyond this scope, please get in touch with the{xportr}team on slack or create an issue to discuss.Please check off each task box as an acknowledgment that you completed the task. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.Changes Description
(descriptions of changes)
Task List
stylerpackage and functions to style files accordingly.devtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelypkgdown::build_site()and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.NEWS.mdif the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers)NEWS.mdentry should go under the# xportr development versionsection. Don't worry about updating the version because it will be auto-updated using thevbump.yamlCI.