Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #174 Specify domain filtering uses environment domain variable #256

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

EeethB
Copy link
Collaborator

@EeethB EeethB commented Mar 6, 2024

Thank you for your Pull Request!

We have developed a Pull Request template to aid you and our reviewers. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the xportr codebase remains robust and consistent.

The scope of {xportr}

{xportr}'s scope is to enable R users to write out submission compliant xpt files that can be delivered to a Health Authority or to downstream validation software programs. We see labels, lengths, types, ordering and formats from a dataset specification object (SDTM and ADaM) as being our primary focus. We also see messaging and warnings to users around applying information from the specification file as a primary focus. Please make sure your Pull Request meets this scope of {xportr}. If your Pull Request moves beyond this scope, please get in touch with the {xportr} team on slack or create an issue to discuss.

Please check off each task box as an acknowledgment that you completed the task. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

Changes Description

Closes #174

Specify domain filtering uses environment variable

Task List

  • The spirit of xportr is met in your Pull Request
  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Summary of changes filled out in the above Changes Description. Can be removed or left blank if changes are minor/self-explanatory.
  • Code is formatted according to the tidyverse style guide. Use styler package and functions to style files accordingly.
  • New functions or arguments follow established convention found in the Wiki.
  • Updated relevant unit tests or have written new unit tests. See our Wiki for conventions used in this package.
  • Creation/updated relevant roxygen headers and examples. See our Wiki for conventions used in this package.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • The NEWS.md entry should go under the # xportr development version section. Don't worry about updating the version because it will be auto-updated using the vbump.yaml CI.
  • Address any updates needed for vignettes and/or templates.
  • Link the issue Development Panel so that it closes after successful merging.
  • The developer is responsible for fixing merge conflicts not the Reviewer.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Copy link

github-actions bot commented Mar 6, 2024

Code Coverage

Package Line Rate Health
xportr 100%
Summary 100% (785 / 785)

@EeethB EeethB marked this pull request as ready for review March 6, 2024 19:50
@bms63 bms63 self-requested a review March 7, 2024 01:56
@bms63 bms63 linked an issue Mar 7, 2024 that may be closed by this pull request
@bms63 bms63 changed the title Specify domain filtering uses environment domain variable Closes #174 Specify domain filtering uses environment domain variable Mar 7, 2024
@bms63
Copy link
Collaborator

bms63 commented Mar 7, 2024

whew!! that was much easier then I thought it was going to be!

@atorus-research/xportr-development-team any misgivings?

@bms63
Copy link
Collaborator

bms63 commented Mar 8, 2024

Original issue author has tested and confirmed fix

@bms63 bms63 merged commit 286a50e into main Mar 8, 2024
15 checks passed
@bms63 bms63 deleted the 137_apply_all_write branch March 8, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: explicitly filter domain variables using .data and .env pronouns
2 participants