fix: Changes to the dmac public API
#764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeaurivage
force-pushed
the
dmac-api
branch
2 times, most recently
from
370449c to
c5c960d
Compare
jbeaurivage
changed the title
dmac public APIdmac public API
|
Now that I think about it, I don't think any of the changes in this PR are breaking. The |
* Remove `BlockTransferControl` and `DmacDescriptor` structs from the API * Add getters/setters for level0, level1, level2 and level3 for `PriorityLevelMask` and `RoundRobinMask` structs
9 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that there were a few mistakes in the public API of the
dmacmodule. Some things were missing, and some others were publicly exposed when they shouldn't.BlockTransferControlandDmacDescriptorstructs from the public APIPriorityLevelMaskandRoundRobinMaskstructs