Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more demo data #233

Merged
merged 4 commits into from
Sep 13, 2024
Merged

feat: more demo data #233

merged 4 commits into from
Sep 13, 2024

Conversation

XavierChanth
Copy link
Member

- What I did

Doubled the number of atSigns in the demo data (by duplicating the existing data and changing the atSign)

- How I did it

- How to verify it

- Description for the changelog
feat: more demo data

Copy link
Member Author

@XavierChanth XavierChanth Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deletions in this file were moved to at_demo_keys.dart and at_demo_apkam_keys.dart. Used the part / part of directive to make these three files appear as if it still were one file.

If you want to skip to the first addition in this file, click here: https://github.com/atsign-foundation/at_demos/pull/233/files#r1746222956

static const String _sachinApkamSymmetricKey =
'J5EzKenByJVhM91omz7Lz/wdaq68HjK9SpEccQIcYYk=';
}
part 'at_demo_keys.dart';
Copy link
Member Author

@XavierChanth XavierChanth Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking the first addition in the file so I can link to it.

Comment on lines -639 to -658
'@alice🛠': AliceKeys._aliceCRAMKey,
'@ashish🛠': AshishKeys._ashishCRAMKey,
'@barbara🛠': BarbaraKeys._barbaraCRAMKey,
'@bob🛠': BobKeys._bobCRAMKey,
'@colin🛠': ColinKeys._colinCRAMKey,
'@egbiometric🛠': EgBiometricKeys._egBiometricCRAMKey,
'@egcovidlab🛠': EgCovidLabKeys._egCovidLabCRAMKey,
'@egcreditbureau🛠': EgCreditBureauKeys._egCreditBureauCRAMKey,
'@eggovagency🛠': EgGovAgencyKeys._egGovAgencyCRAMKey,
'@emoji🦄🛠': EmojiKeys._emojiCRAMKey,
'@eve🛠': EveKeys._eveCRAMKey,
'@jagan🛠': JaganKeys._jaganCRAMKey,
'@kevin🛠': KevinKeys._kevinCRAMKey,
'@murali🛠': MuraliKeys._muraliCRAMKey,
'@naresh🛠': NareshKeys._nareshCRAMKey,
'@purnima🛠': PurnimaKeys._purnimaCRAMKey,
'@sameeraja🛠': SameerajaKeys._sameerajaCRAMKey,
'@sitaram🛠': SitaramKeys._sitaramCRAMKey,
'@srie': SrieKeys._srieCRAMKey,
'@sachin': SachinKeys._sachinCRAMKey
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed all of these, removing the name from the variable. Example:
SachinKeys._sachinCRAMKey > SachinKeys._cramKey.

It's a private variable, so we know (and I've updated) all the places affected (only files linked via part/part of directive) and thus it is also a non-breaking change.

I only did this rename because it made it easier to duplicate and rename the classes

Copy link
Member

@cconstab cconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very fiddly but TY

@XavierChanth XavierChanth merged commit bf8d223 into trunk Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants