refactor: Full re-write of SDK #22
Conversation
…f dependency inversion
… it can be used as a trait object
…nstructing different types of AtKeys
|
Thanks @Zambrella Can you please take a look at the clippy warnings and fix them up (you might even be able to use it to implement the suggested fixes). |
|
@cpswan Clippy warnings have been fixed :) |
There was a problem hiding this comment.
@Zambrella thanks for this. It's a brilliant contribution :)
Secondly my apologies that it's taken me so long to review. It's a big PR and I wanted the chance to properly test it. It took some travel disruption and an unexpected change to my weekend to clear a bit of time.
There are a few minor tweaks I'd love to have before merging, but if you don't have the bandwidth to come back to this right now then that's entirely understandable. So I'm approving and will merge anyway in a week or so if I don't hear from you.
| "at_sign", | ||
| "at_tls", | ||
| "at_verbs", | ||
| ] } | ||
| [package] | ||
| name = "at_rust" | ||
| version = "0.2.1" |
There was a problem hiding this comment.
Please bump the version to 0.3.0
There was a problem hiding this comment.
We really shouldn't have binaries in the repo. Could these be substituted with text encoded keys?
- What I did
I re-wrote the code from scratch to allow for better extensibility and maintainability (and for fun). There is no additional functionality (yet) from the previous version. The main changes include:
RustCryptocrates for crypto because it is written in pure Rust so should be compatible with more hardwarerustlscrate for TLS which should have broader compatibility that the previous crate that was being used- How to verify it
README.md)README.md) and check the data is read and written correctly and can be accessed by other SDKs- Description for the changelog
Full re-write of SDK