Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump dart from 3.0.7 to 3.1.0 in /tools/build_virtual_environment/ve_base #1516

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 21, 2023

Bumps dart from 3.0.7 to 3.1.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps dart from 3.0.7 to 3.1.0.

---
updated-dependencies:
- dependency-name: dart
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Aug 21, 2023
dependabot bot and others added 6 commits August 21, 2023 00:20
Bumps dart from 3.0.7 to 3.1.0.

---
updated-dependencies:
- dependency-name: dart
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps dart from 3.0.7 to 3.1.0.

---
updated-dependencies:
- dependency-name: dart
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps dart from 3.0.7 to 3.1.0.

---
updated-dependencies:
- dependency-name: dart
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Member

@cpswan cpswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to figure out why at_dockerfiles isn't building before we merge Dart 3.1.0

@cpswan
Copy link
Member

cpswan commented Aug 30, 2023

@purnimavenkatasubbu @murali-shris @sitaram-kalluri @gkc

I'm not going to merge this yet as I'm seeing pretty consistent failures (across 3 runs) on end2end tests that don't feel like flakiness:

On end2end_test_34:

❌ test/notify_verb_test.dart: notify verb for deleting a key for other atsign (failed)
  Clearing socket response queues
  command sent: notify:delete:messageType:key:notifier:system:ttr:-1:@cicd4:email@cicd3
  Response: data:1938214d-aaa6-4d5f-a2b0-0eee99ad1921
  notify verb response : data:1938214d-aaa6-4d5f-a2b0-0eee99ad1921
  getNotifyStatus will check for notify:status response in '[delivered]' for 15000
  command sent: notify:status:1938214d-aaa6-4d5f-a2b0-0eee99ad1921
  Response: data:delivered
  getNotifyStatus return with response data:delivered (was waiting for '[delivered]')
  notify status response : data:delivered
  command sent: notify:list:email
  Response: data:[{"id":"1938214d-aaa6-4d5f-a2b0-0eee99ad1921","from":"@cicd3","to":"@cicd4","key":"@cicd4:email@cicd3","value":null,"operation":"delete","epochMillis":1693401609978,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"8a406b01-8f89-4f89-8700-f1c973813a0a","from":"@cicd3","to":"@cicd4","key":"@cicd4:email@cicd3","value":null,"operation":"delete","epochMillis":1693401215301,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"9298b871-b826-43d4-a679-b2b5c4c8cb7a","from":"@cicd3","to":"@cicd4","key":"@cicd4:email@cicd3","value":null,"operation":"delete","epochMillis":1693401428220,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}}]
  notify list verb response : data:[{"id":"1938214d-aaa6-4d5f-a2b0-0eee99ad1921","from":"@cicd3","to":"@cicd4","key":"@cicd4:email@cicd3","value":null,"operation":"delete","epochMillis":1693401609978,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"8a406b01-8f89-4f89-8700-f1c973813a0a","from":"@cicd3","to":"@cicd4","key":"@cicd4:email@cicd3","value":null,"operation":"delete","epochMillis":1693401215301,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"9298b871-b826-43d4-a679-b2b5c4c8cb7a","from":"@cicd3","to":"@cicd4","key":"@cicd4:email@cicd3","value":null,"operation":"delete","epochMillis":1693401428220,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}}]
  Expected: contains '"key":"@cicd4:email@cicd3","value":"null","operation":"delete"'
    Actual: 'data:[{"id":"1938214d-aaa6-4d5f-a2b0-0eee99ad1921","from":"@cicd3","to":"@cicd4","key":"@cicd4:email@cicd3","value":null,"operation":"delete","epochMillis":1693401609978,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"8a406b01-8f89-4f89-8700-f1c973813a0a","from":"@cicd3","to":"@cicd4","key":"@cicd4:email@cicd3","value":null,"operation":"delete","epochMillis":1693401215301,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"9298b871-b826-43d4-a679-b2b5c4c8cb7a","from":"@cicd3","to":"@cicd4","key":"@cicd4:email@cicd3","value":null,"operation":"delete","epochMillis":1693401428220,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}}]'
     Which: does not contain '"key":"@cicd4:email@cicd3","value":"null","operation":"delete"'
  
  package:matcher                   expect
  test/notify_verb_test.dart 200:5  main.<fn>

and end2end_test_56:

❌ test/notify_verb_test.dart: notify verb without messageType and operation (failed)
  Clearing socket response queues
  command sent: notify:@cicd5:contact-no@cicd6:+91-90128234620
  Response: data:db3d5706-f952-4462-a5df-715032a57cbc
  notify verb response : data:db3d5706-f952-4462-a5df-715032a57cbc
  getNotifyStatus will check for notify:status response in '[delivered]' for 15000
  command sent: notify:status:db3d5706-f952-4462-a5df-715032a57cbc
  Response: data:delivered
  getNotifyStatus return with response data:delivered (was waiting for '[delivered]')
  notify status response : data:delivered
  command sent: notify:list
  Response: data:[{"id":"161e0c12-5408-4673-84c5-095e7c4ca86d","from":"@cicd6","to":"@cicd5","key":"@cicd5:twitter-id@cicd6","value":null,"operation":"delete","epochMillis":1693401356723,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"1ec65242-d7e1-48b8-8fc3-d14d43f47233","from":"@cicd6","to":"@cicd5","key":"@cicd5:hello_world","value":null,"operation":"update","epochMillis":1693401349187,"messageType":"MessageType.text","isEncrypted":false,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"2ee75827-9b47-49c1-8034-ae0508df771a","from":"@cicd6","to":"@cicd5","key":"@cicd5:nottrkey@cicd6","value":null,"operation":"update","epochMillis":1693401347430,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"4c19f751-50e0-4544-9096-e415f749d910","from":"@cicd6","to":"@cicd5","key":"@cicd5:19-Hey,Hello!","value":null,"operation":"update","epochMillis":1693401358490,"messageType":"MessageType.text","isEncrypted":false,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"57b4015d-2089-4e44-a616-051fadc1e3b0","from":"@cicd6","to":"@cicd5","key":"@cicd5:fav-city@cicd6","value":"22-Hyderabad","operation":"update","epochMillis":1693401157388,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"69bb5410-cad3-45df-88b7-43291478299b","from":"@cicd6","to":"@cicd5","key":"@cicd5:email@cicd6","value":"alice22@yahoo.com","operation":"update","epochMillis":1693401152924,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"6e875dc6-f476-4a53-b8c9-04538fe0efc9","from":"@cicd6","to":"@cicd5","key":"@cicd5:contact-no@cicd6","value":"+91-90128234622","operation":"update","epochMillis":1693401155591,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"810d9a09-1a84-4f36-bb8d-a60415acbeb7","from":"@cicd6","to":"@cicd5","key":"@cicd5:email@cicd6","value":"alice19@yahoo.com","operation":"update","epochMillis":1693401338631,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"8840a998-3aa1-4958-abb3-e98487570f42","from":"@cicd6","to":"@cicd5","key":"@cicd5:contact-no@cicd6","value":"+91-90128234619","operation":"update","epochMillis":1693401342153,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"90dd1cb9-ed88-498d-8596-8747dd05c362","from":"@cicd6","to":"@cicd5","key":"@cicd5:fav-city@cicd6","value":"19-Hyderabad","operation":"update","epochMillis":1693401343914,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"932b30a6-d72f-49e8-ab89-6b7f238[518](https://github.com/atsign-foundation/at_server/actions/runs/6025295731/job/16346017761#step:7:562)e1","from":"@cicd6","to":"@cicd5","key":"@cicd5:hello_world","value":null,"operation":"delete","epochMillis":1693401350944,"messageType":"MessageType.text","isEncrypted":false,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"9fb771ce-a94e-4d02-9da8-56d5e13d8594","from":"@cicd6","to":"@cicd5","key":"@cicd5:22-Hey,Hello!","value":null,"operation":"update","epochMillis":1693401159139,"messageType":"MessageType.text","isEncrypted":false,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"d101ae2c-75a1-4012-8e7a-fa05f4364328","from":"@cicd6","to":"@cicd5","key":"@cicd5:testkey@cicd6","value":"testingvalue","operation":"update","epochMillis":1693401345672,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"db3d5706-f952-4462-a5df-715032a57cbc","from":"@cicd6","to":"@cicd5","key":"@cicd5:contact-no@cicd6","value":"+91-90128234620","operation":"update","epochMillis":1693401537014,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"e049732b-b7a3-4b38-a226-3f684a6802f6","from":"@cicd6","to":"@cicd5","key":"@cicd5:email@cicd6","value":"alice20@yahoo.com","operation":"update","epochMillis":1693401533491,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}}]
  notify list verb response : data:[{"id":"161e0c12-5408-4673-84c5-095e7c4ca86d","from":"@cicd6","to":"@cicd5","key":"@cicd5:twitter-id@cicd6","value":null,"operation":"delete","epochMillis":1693401356723,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"1ec6[524](https://github.com/atsign-foundation/at_server/actions/runs/6025295731/job/16346017761#step:7:568)2-d7e1-48b8-8fc3-d14d43f47233","from":"@cicd6","to":"@cicd5","key":"@cicd5:hello_world","value":null,"operation":"update","epochMillis":1693401349187,"messageType":"MessageType.text","isEncrypted":false,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"2ee75827-9b47-49c1-8034-ae0508df771a","from":"@cicd6","to":"@cicd5","key":"@cicd5:nottrkey@cicd6","value":null,"operation":"update","epochMillis":1693401347430,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"4c19f751-50e0-4544-9096-e415f749d910","from":"@cicd6","to":"@cicd5","key":"@cicd5:19-Hey,Hello!","value":null,"operation":"update","epochMillis":1693401358490,"messageType":"MessageType.text","isEncrypted":false,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"57b4015d-2089-4e44-a616-051fadc1e3b0","from":"@cicd6","to":"@cicd5","key":"@cicd5:fav-city@cicd6","value":"22-Hyderabad","operation":"update","epochMillis":1693401157388,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"69bb5410-cad3-45df-88b7-43291478299b","from":"@cicd6","to":"@cicd5","key":"@cicd5:email@cicd6","value":"alice22@yahoo.com","operation":"update","epochMillis":16934011[529](https://github.com/atsign-foundation/at_server/actions/runs/6025295731/job/16346017761#step:7:573)24,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"6e875dc6-f476-4a53-b8c9-04538fe0efc9","from":"@cicd6","to":"@cicd5","key":"@cicd5:contact-no@cicd6","value":"+91-90128234622","operation":"update","epochMillis":1693401155591,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"810d9a09-1a84-4f36-bb8d-a60415acbeb7","from":"@cicd6","to":"@cicd5","key":"@cicd5:email@cicd6","value":"alice19@yahoo.com","operation":"update","epochMillis":1693401338631,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"8840a998-3aa1-4958-abb3-e98487570f42","from":"@cicd6","to":"@cicd5","key":"@cicd5:contact-no@cicd6","value":"+91-90128234619","operation":"update","epochMillis":1693401342153,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"90dd1cb9-ed88-498d-8596-8747dd05c362","from":"@cicd6","to":"@cicd5","key":"@cicd5:fav-city@cicd6","value":"19-Hyderabad","operation":"update","epochMillis":1693401343914,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"932b30a6-d72f-49e8-ab89-6b7f238518e1","from":"@cicd6","to":"@cicd5","key":"@cicd5:hello_world","value":null,"operation":"delete","epochMillis":1693401350944,"messageType":"MessageType.text","isEncrypted":false,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"9fb771ce-a94e-4d02-9da8-56d5e13d8594","from":"@cicd6","to":"@cicd5","key":"@cicd5:22-Hey,Hello!","value":null,"operation":"update","epochMillis":1693401159139,"messageType":"MessageType.text","isEncrypted":false,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"d101ae2c-75a1-4012-8e7a-fa05f4364328","from":"@cicd6","to":"@cicd5","key":"@cicd5:testkey@cicd6","value":"testingvalue","operation":"update","epochMillis":1693401345672,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"db3d5706-f952-4462-a5df-715032a57cbc","from":"@cicd6","to":"@cicd5","key":"@cicd5:contact-no@cicd6","value":"+91-90128234620","operation":"update","epochMillis":1693401537014,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"e049732b-b7a3-4b38-a226-3f684a6802f6","from":"@cicd6","to":"@cicd5","key":"@cicd5:email@cicd6","value":"alice20@yahoo.com","operation":"update","epochMillis":1693401533491,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}}]
  Expected: contains '"key":"@cicd5:contact-no@cicd6","value":null'
    Actual: 'data:[{"id":"161e0c12-5408-4673-84c5-095e7c4ca86d","from":"@cicd6","to":"@cicd5","key":"@cicd5:twitter-id@cicd6","value":null,"operation":"delete","epochMillis":1693401356723,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"1ec65242-d7e1-48b8-8fc3-d14d43f47233","from":"@cicd6","to":"@cicd5","key":"@cicd5:hello_world","value":null,"operation":"update","epochMillis":1693401349187,"messageType":"MessageType.text","isEncrypted":false,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"2ee75827-9b47-49c1-8034-ae0508df771a","from":"@cicd6","to":"@cicd5","key":"@cicd5:nottrkey@cicd6","value":null,"operation":"update","epochMillis":1693401347430,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"4c19f751-50e0-4544-9096-e415f749d910","from":"@cicd6","to":"@cicd5","key":"@cicd5:19-Hey,Hello!","value":null,"operation":"update","epochMillis":1693401358490,"messageType":"MessageType.text","isEncrypted":false,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"57b4015d-2089-4e44-a616-051fadc1e3b0","from":"@cicd6","to":"@cicd5","key":"@cicd5:fav-city@cicd6","value":"22-Hyderabad","operation":"update","epochMillis":1693401157388,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"69bb5410-cad3-45df-88b7-43291478299b","from":"@cicd6","to":"@cicd5","key":"@cicd5:email@cicd6","value":"alice22@yahoo.com","operation":"update","epochMillis":1693401152924,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"6e875dc6-f476-4a53-b8c9-04538fe0efc9","from":"@cicd6","to":"@cicd5","key":"@cicd5:contact-no@cicd6","value":"+91-90128234622","operation":"update","epochMillis":1693401155591,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"810d9a09-1a84-4f36-bb8d-a60415acbeb7","from":"@cicd6","to":"@cicd5","key":"@cicd5:email@cicd6","value":"alice19@yahoo.com","operation":"update","epochMillis":1693401338631,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"8840a998-3aa1-4958-abb3-e98487570f42","from":"@cicd6","to":"@cicd5","key":"@cicd5:contact-no@cicd6","value":"+91-90128234619","operation":"update","epochMillis":1693401342153,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"90dd1cb9-ed88-498d-8596-8747dd05c362","from":"@cicd6","to":"@cicd5","key":"@cicd5:fav-city@cicd6","value":"19-Hyderabad","operation":"update","epochMillis":1693401343914,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"932b30a6-d72f-49e8-ab89-6b7f238518e1","from":"@cicd6","to":"@cicd5","key":"@cicd5:hello_world","value":null,"operation":"delete","epochMillis":1693401350944,"messageType":"MessageType.text","isEncrypted":false,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"9fb771ce-a94e-4d02-9da8-56d5e13d8594","from":"@cicd6","to":"@cicd5","key":"@cicd5:22-Hey,Hello!","value":null,"operation":"update","epochMillis":1693401159139,"messageType":"MessageType.text","isEncrypted":false,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"d101ae2c-75a1-4012-8e7a-fa05f4364328","from":"@cicd6","to":"@cicd5","key":"@cicd5:testkey@cicd6","value":"testingvalue","operation":"update","epochMillis":1693401345672,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"db3d5706-f952-4462-a5df-715032a57cbc","from":"@cicd6","to":"@cicd5","key":"@cicd5:contact-no@cicd6","value":"+91-90128234620","operation":"update","epochMillis":1693401537014,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}},{"id":"e049732b-b7a3-4b38-a226-3f684a6802f6","from":"@cicd6","to":"@cicd5","key":"@cicd5:email@cicd6","value":"alice20@yahoo.com","operation":"update","epochMillis":1693401533491,"messageType":"MessageType.key","isEncrypted":true,"metadata":{"encKeyName":null,"encAlgo":null,"ivNonce":null,"skeEncKeyName":null,"skeEncAlgo":null}}]'
     Which: does not contain '"key":"@cicd5:contact-no@cicd6","value":null'
  
  package:matcher                   expect
  test/notify_verb_test.dart 124:5  main.<fn>

Copy link
Member

@cpswan cpswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to merge this until we understand why end2end cross tests are consistently failing.

@sitaram-kalluri
Copy link
Member

@cpswan : I am looking into the issue.

@sitaram-kalluri
Copy link
Member

@cpswan and @gkc:

All the tests passed now.

Here is analysis on why tests failed previously.

Expected: contains '"key":"@cicd4:email@cicd3","value":"null","operation":"delete"'
Actual: 'data:[{"key":"@cicd4:email@cicd3","value":null,"operation":"delete",

In expected, "value" contains "null" where as the actual is null which is causing the issue.

The only change with respect to notifications we made are in the following PR: #1530 related to notify_ephemeral. However, the changes are in feature branch and still not merged to trunk, really unsure on how this might have affected the end-to-end servers.

Copy link
Member

@cpswan cpswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sitaram-kalluri for getting the tests straightened out.

@cpswan cpswan merged commit 09fecd4 into trunk Aug 31, 2023
17 checks passed
@cpswan cpswan deleted the dependabot/docker/tools/build_virtual_environment/ve_base/dart-3.1.0 branch August 31, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants