Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LatestCommitEntryOfEachKey bug due to commit log getEntries default limit 25 #2099

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix: LatestCommitEntryOfEachKey bug due to commit log getEntries default limit 25 #2099

merged 3 commits into from
Sep 25, 2024

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Sep 24, 2024 •
edited
Loading

Fixed atsign-foundation/at_client_sdk#1404
- What I did

  • Fixed a bug in LatestCommitEntryOfEachKey --> getMetrics which was returning only 25(default limit)
    - How I did it
  • Added pagination logic in the method to get entries till lastCommitID
  • added unit test
    - How to verify it
  • tests should pass

@murali-shris murali-shris changed the title feat: LatestCommitEntryOfEachKey bug due to sync buffer default value 25 feat: LatestCommitEntryOfEachKey bug due to commit log getEntries default limit 25 Sep 24, 2024
@murali-shris murali-shris changed the title feat: LatestCommitEntryOfEachKey bug due to commit log getEntries default limit 25 fix: LatestCommitEntryOfEachKey bug due to commit log getEntries default limit 25 Sep 24, 2024
@murali-shris murali-shris marked this pull request as ready for review September 24, 2024 17:01
@murali-shris murali-shris mentioned this pull request Sep 25, 2024
Merged
@murali-shris murali-shris merged commit 19da367 into trunk Sep 25, 2024
26 checks passed
@murali-shris murali-shris deleted the sync_get_entries_bug branch September 25, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitaram-kalluri sitaram-kalluri sitaram-kalluri approved these changes

@gkc gkc gkc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sync multiple client functional test fails intermittently
3 participants
@murali-shris @gkc @sitaram-kalluri