Merge pull request #204 from atsign-foundation/bypass_cache_rename

feat: rename byPassCache to bypassCache
atsign-foundation · Jul 11, 2022 · 42809fd · 42809fd
2 parents 7126dd2 + e3329a4
commit 42809fd
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 10 deletions.
diff --git a/at_commons/CHANGELOG.md b/at_commons/CHANGELOG.md
@@ -1,3 +1,5 @@
+## 3.0.19
+- Rename byPassCache to bypassCache in lookup, plookup verb builders and at_constants
 ## 3.0.18
 - Add 'showHidden' to scan regex to display hidden keys when set to true
 ## 3.0.17

diff --git a/at_commons/lib/src/at_constants.dart b/at_commons/lib/src/at_constants.dart
@@ -65,5 +65,5 @@ const String commitLogCompactionKey = 'privatekey:commitLogCompactionStats';
 const String accessLogCompactionKey = 'privatekey:accessLogCompactionStats';
 const String notificationCompactionKey =
     'privatekey:notificationCompactionStats';
-const String byPassCache = 'bypassCache';
+const String bypassCache = 'bypassCache';
 const String showHidden = 'showhidden';
diff --git a/at_commons/lib/src/verb/lookup_verb_builder.dart b/at_commons/lib/src/verb/lookup_verb_builder.dart
@@ -27,13 +27,13 @@ class LookupVerbBuilder implements VerbBuilder {
   String? operation;
 
   // if set to true, returns the value of key on the remote server instead of the cached copy
-  bool byPassCache = false;
+  bool bypassCache = false;
 
   @override
   String buildCommand() {
     String command = 'lookup:';
-    if (byPassCache == true) {
-      command += 'bypassCache:$byPassCache:';
+    if (bypassCache == true) {
+      command += 'bypassCache:$bypassCache:';
     }
     if (operation != null) {
       command += '$operation:';

diff --git a/at_commons/lib/src/verb/plookup_verb_builder.dart b/at_commons/lib/src/verb/plookup_verb_builder.dart
@@ -18,13 +18,13 @@ class PLookupVerbBuilder implements VerbBuilder {
   String? operation;
 
   // if set to true, returns the value of key on the remote server instead of the cached copy
-  bool byPassCache = false;
+  bool bypassCache = false;
 
   @override
   String buildCommand() {
     String command = 'plookup:';
-    if (byPassCache == true) {
-      command += 'bypassCache:$byPassCache:';
+    if (bypassCache == true) {
+      command += 'bypassCache:$bypassCache:';
     }
     if (operation != null) {
       command += '$operation:';

diff --git a/at_commons/pubspec.yaml b/at_commons/pubspec.yaml
@@ -1,6 +1,6 @@
 name: at_commons
 description: A library of Dart and Flutter utility classes that are used across other components of the @‎platform.
-version: 3.0.18
+version: 3.0.19
 repository: https://github.com/atsign-foundation/at_tools
 homepage: https://atsign.dev
 

diff --git a/at_commons/test/lookup_verb_builder_test.dart b/at_commons/test/lookup_verb_builder_test.dart
@@ -27,7 +27,7 @@ void main() {
 
     test('verify lookup bypass cache command', () {
       var lookupVerbBuilder = LookupVerbBuilder()
-        ..byPassCache = true
+        ..bypassCache = true
         ..atKey = 'email'
         ..sharedBy = 'alice';
       expect(lookupVerbBuilder.buildCommand(),

diff --git a/at_commons/test/plookup_verb_builder_test.dart b/at_commons/test/plookup_verb_builder_test.dart
@@ -27,7 +27,7 @@ void main() {
 
     test('verify plookup bypass cache command', () {
       var plookupVerbBuilder = PLookupVerbBuilder()
-        ..byPassCache = true
+        ..bypassCache = true
         ..atKey = 'email'
         ..sharedBy = 'alice';
       expect(plookupVerbBuilder.buildCommand(),