Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make necessary changes for alpha.6 #31

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jtraglia
Copy link

@jtraglia jtraglia commented Sep 25, 2024

Most of this PR is undo-ing things, which is a nice change 😄

  • Electra doesn't make any changes to ExecutionPayload now.
    • So replace electra.ExecutionPayload with deneb.ExecutionPayload.
  • Because we use the same payload as Deneb, we no longer need any new API types.
    • So we can delete the whole api/electra directory.
  • Consolidations/withdraws/etc are no longer in the payload.
    • So we can delete the getter functions for those in:
      • VersionedSubmitBlindedBlockResponse
      • VersionedSubmitBlockRequest

Note: I've added a replace directive in go.mod to @pk910's go-eth2-client branch.
When his branch has been merged into attestantio's electra branch, delete this.

@mcdee mcdee merged commit 54c4c51 into attestantio:electra Sep 25, 2024
1 of 2 checks passed
@jtraglia jtraglia deleted the electra-alpha.6 branch September 25, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants