Skip to content

Rework API

Rework API #433

Triggered via pull request October 16, 2023 11:08
@mcdeemcdee
synchronize #80
rework-api
Status Failure
Total duration 26s
Artifacts

golangci-lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors
lint: http/http.go#L306
http/http.go:306: Line contains TODO/BUG/FIXME: "TODO can we pass the reader? Or does ca..." (godox)
lint: http/http.go#L394
http/http.go:394: Line contains TODO/BUG/FIXME: "TODO need to be selective here?" (godox)
lint: http/http.go#L163
(*Service).post2 - result 0 (io.Reader) is never used (unparam)
lint: multi/submitbeaconblock.go#L26
SA1019: client.(consensusclient.BeaconBlockSubmitter).SubmitBeaconBlock is deprecated: this will not work from the deneb hard-fork onwards. Use ProposalSubmitter.SubmitProposal() instead. (staticcheck)
lint: multi/submitblindedbeaconblock.go#L26
SA1019: client.(consensusclient.BlindedBeaconBlockSubmitter).SubmitBlindedBeaconBlock is deprecated: this will not work from the deneb hard-fork onwards. Use BlindedProposalSubmitter.SubmitBlindedProposal() instead. (staticcheck)
lint: testclients/erroring.go#L405
SA1019: next.SubmitBeaconBlock is deprecated: this will not work from the deneb hard-fork onwards. Use ProposalSubmitter.SubmitProposal() instead. (staticcheck)
lint: testclients/erroring.go#L431
SA1019: next.SubmitBlindedBeaconBlock is deprecated: this will not work from the deneb hard-fork onwards. Use BlindedProposalSubmitter.SubmitBlindedProposal() instead. (staticcheck)
lint: testclients/sleepy.go#L294
SA1019: next.SubmitBeaconBlock is deprecated: this will not work from the deneb hard-fork onwards. Use ProposalSubmitter.SubmitProposal() instead. (staticcheck)
lint: testclients/sleepy.go#L327
SA1019: next.SubmitBlindedBeaconBlock is deprecated: this will not work from the deneb hard-fork onwards. Use BlindedProposalSubmitter.SubmitBlindedProposal() instead. (staticcheck)
lint
issues found