Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for reduced memory usage #121

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

nkryuchkov
Copy link
Contributor

This PR supersedes #105 and uses the approach described in #105 (comment).

Changes:

  • Add an option for HTTP Service that reduces memory usage by disabling certain actions that may take a significant amount of memory
  • Optionally disable fetching validators from the state in the Validators call. The superseded PR has more details about this case

Copy link
Contributor

@mcdee mcdee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. One change, apart from that it looks good.

http/validators.go Outdated Show resolved Hide resolved
nkryuchkov added a commit to ssvlabs/ssv that referenced this pull request Mar 25, 2024
@nkryuchkov nkryuchkov requested a review from mcdee March 25, 2024 14:32
@mcdee mcdee merged commit 858fa8a into attestantio:master Mar 25, 2024
2 checks passed
y0sher pushed a commit to ssvlabs/ssv that referenced this pull request May 19, 2024
* Use unified block production from updated eth2 client

* Deploy to 21-24

* Revert "Deploy to 21-24"

This reverts commit e051e44.

* Get rid of BUILDER_PROPOSALS flag

* Use eth2 client from attestantio/go-eth2-client#121

* Deploy to 21-24

* Update ca-certificates version

* Don't use eth2 client fork

* Use new eth2 client version in e2e

* Fix TestTimeouts

* Deploy to all stage nodes

* Deploy to 1-56

* e2e go mod tidy

* Disable deployment

* change to fixed version of ssv-spec

* add logs

* checkout

* test on stage

* test on stage

* upgrade go-eth2-client and deploy to stage

* deploy to stage

* removed BuilderProposals flag

* removed DelayedStart

* removed unused log

* approve diff

* approve metrics spec diff

* replace spec repo to ssvlabs in go.mod only

* restore gitlab-ci to originl settings

* add tests to differ

* approve spec diffs

* remove BUILDER_PROPOSALS after merge

* update spec

* point to the right comment on ssv-spec(temp)

* extract transformer to a package

* Revert "extract transformer to a package"

This reverts commit 4ba8ad9.

---------

Co-authored-by: guy muroch <guym@blox.io>
Co-authored-by: moshe-blox <moshe@blox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants