(g *Gwei) UnmarshalJSON()
panic
on malformed input
#122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently running Nosy on a broad set of ethereum client dependencies. It found a few panics while fuzzing
go-eth2-client
. This fixes an issues in(g *Gwei) UnmarshalJSON()
where apanic: runtime error: slice bounds out of range
is triggerable due to a malformed JSON token.Summary:
(g *Gwei) UnmarshalJSON()
has a few checks upon entry to prevent issues but apanic
can still be triggered if a single"
character is provided.This bypasses the
len(input) == 0
check as well as the prefix and suffix checks, since the single"
character matches.The panic happens on the slice indexing shortly after:
This PR adds a minimum length check for a valid entry to
(g *Gwei) UnmarshalJSON()
as well as a test for the malformed input.