Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Makefile with a fmt rule #128

Closed
wants to merge 2 commits into from
Closed

Add a Makefile with a fmt rule #128

wants to merge 2 commits into from

Conversation

jtraglia
Copy link
Contributor

@jtraglia jtraglia commented Apr 5, 2024

This PR adds the ability to run make fmt which will automatically format everything. I think this would be a nice addition because (1) consistency is good and (2) after making a lot of changes it's nice knowing that everything is formatted properly and the imports are in a rational order.

@mcdee
Copy link
Contributor

mcdee commented Apr 22, 2024

I'm not a big fan of having additional commands that need to be run outside of the existing workflow, because it's easy for them to not be run. That said, there is value in being stricter about formatting and the like.

I have added some additional linting rules and tidied up the code according to said rules and that seems to get us most of the way there. This is easier to maintain, as it will run on every PR as part of the merge checks and allows them to be picked up by the PR author without us having to wonder if they ran the linting commands or not.

@jtraglia jtraglia closed this Apr 30, 2024
@jtraglia jtraglia deleted the make-fmt branch May 6, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants