-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start to add support for Electra #131
Conversation
I added two
Not really sure how I would make these less complex. |
The Electra changes themselves look good. There are a fair number of non-Electra changes in here. Would it be possible to remove these from this PR, to avoid additional pain when we come to merge this branch back into master? Anything non-cosmetic can be pushed to a separate PR to be included directly into master. Thanks. |
Yes, good suggestion. I'll make those changes first thing tomorrow morning. |
I've undone the non-electra changes except for the new Epoch marshaling functions in I made these PRs to master: |
This PR makes the necessary changes (adds new structures and updates versioned structures) for Electra. Sorry, it contains a lot of new files and it lacks tests. I would like to pull in these changes into an electra branch, so that multiple people (myself included) can add tests later, in smaller PRs. After this PR gets merged, I'll make the equivalent PR for
go-builder-client
. We need to wait becausego-eth2-client
is a dependency and it currently needs areplace
directive.