Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node peering rework #84

Merged
merged 16 commits into from
Oct 24, 2023
Merged

Node peering rework #84

merged 16 commits into from
Oct 24, 2023

Conversation

0xTylerHolmes
Copy link
Contributor

NodePeer implementation with api rework, mock, test, and multi client implementations.

@0xTylerHolmes
Copy link
Contributor Author

see #82

mcdee
mcdee requested changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@mcdee mcdee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rework. A few areas where either the underlying API is inconsistent or the return data is a little involved, apart from that looking good.

api/v1/peers.go Outdated Show resolved Hide resolved
api/peeropts.go Show resolved Hide resolved
api/v1/attesterduty_test.go Outdated Show resolved Hide resolved
http/nodepeers.go Outdated Show resolved Hide resolved
mcdee
mcdee reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@mcdee mcdee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; please could you address the few outstanding items from the linter, then should be good to go.

@mcdee mcdee merged commit 4121cb1 into attestantio:master Oct 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdee mcdee mcdee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xTylerHolmes @mcdee