Skip to content

Commit

Permalink
Fix the null string validation. (#24)
Browse files Browse the repository at this point in the history
* Fix the null string validation.
* Update version to 0.4.1.
  • Loading branch information
aueda authored Dec 19, 2019
1 parent e2463d0 commit 960961d
Show file tree
Hide file tree
Showing 6 changed files with 59 additions and 1 deletion.
16 changes: 16 additions & 0 deletions Maoli.Tests/CepTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,22 @@ public void ConstructorThrowsExceptionIfCepIsInvalidAndStrict()
});
}

[Fact]
public void ValidateReturnsFalseIfCepIsNull()
{
var actual = Cep.Validate(null);

Assert.False(actual);
}

[Fact]
public void StrictValidateReturnsFalseIfCepIsNull()
{
var actual = Cep.Validate(null, CepPunctuation.Strict);

Assert.False(actual);
}

[Fact]
public void ValidateReturnsTrueIfCepIsEmpty()
{
Expand Down
16 changes: 16 additions & 0 deletions Maoli.Tests/CnpjTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,22 @@ public void ValidateReturnsFalseIfCnpjContainsInvalidChars()
Assert.False(actual);
}

[Fact]
public void ValidateReturnsFalseIfCnpjIsNull()
{
var actual = Cnpj.Validate(null);

Assert.False(actual);
}

[Fact]
public void StrictValidateReturnsFalseIfCnpjIsNull()
{
var actual = Cnpj.Validate(null, CnpjPunctuation.Strict);

Assert.False(actual);
}

[Fact]
public void ValidateReturnsFalseIfCnpjIsEmpty()
{
Expand Down
16 changes: 16 additions & 0 deletions Maoli.Tests/CpfTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,22 @@ public void LooseParseThrowsArgumentExceptionIfCpfIsNotValid()
Assert.True(actual);
}

[Fact]
public void ValidateReturnsFalseIfCpfIsNull()
{
var actual = Cpf.Validate(null);

Assert.False(actual);
}

[Fact]
public void StrictValidateReturnsFalseIfCpfIsNull()
{
var actual = Cpf.Validate(null, CpfPunctuation.Strict);

Assert.False(actual);
}

[Fact]
public void LooseParseThrowsArgumentExceptionIfCpfIsEmpty()
{
Expand Down
2 changes: 1 addition & 1 deletion Maoli/Maoli.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Company />
<Copyright>Copyright (c) 2019 Adriano Ueda</Copyright>
<Description>Maoli is a C# helper library for common Brazilian business rules (CPF, CNPJ and CEP). For documentation visit https://github.com/aueda/maoli</Description>
<Version>0.4.0</Version>
<Version>0.4.1</Version>
<PackageLicenseUrl>http://opensource.org/licenses/MIT</PackageLicenseUrl>
<PackageProjectUrl>https://github.com/aueda/maoli</PackageProjectUrl>
<IncludeSymbols>true</IncludeSymbols>
Expand Down
5 changes: 5 additions & 0 deletions Maoli/V2/CnpjHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ internal static bool Validate(string value, CnpjPunctuation punctuation)
{
var isValid = false;

if (value == null)
{
return isValid;
}

if (punctuation == CnpjPunctuation.Strict)
{
isValid =
Expand Down
5 changes: 5 additions & 0 deletions Maoli/V2/CpfHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,11 @@ internal static bool Validate(string value, CpfPunctuation punctuation)
{
var isValid = false;

if (value == null)
{
return isValid;
}

if (punctuation == CpfPunctuation.Strict)
{
isValid =
Expand Down

0 comments on commit 960961d

Please sign in to comment.