Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions workflow [SDK-4433] #307

Merged
merged 193 commits into from
Oct 18, 2023
Merged

Add GitHub Actions workflow [SDK-4433] #307

merged 193 commits into from
Oct 18, 2023

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Sep 15, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

This PR adds a workflow for running all CI checks using GitHub Actions. The CircleCI configuration will be removed in a follow-up PR.

This required changes to the native setup of the example app, for example, changing the way JaCoCo was used to collect coverage.

Screenshot 2023-09-15 at 5 34 15 PM

@Widcket Widcket temporarily deployed to internal September 15, 2023 21:03 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal September 15, 2023 21:03 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal September 15, 2023 21:03 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal September 15, 2023 22:24 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal September 15, 2023 22:24 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal September 15, 2023 22:24 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal September 15, 2023 22:24 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal September 15, 2023 23:16 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal September 15, 2023 23:16 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal September 15, 2023 23:16 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal September 15, 2023 23:16 — with GitHub Actions Inactive
@evansims
Copy link
Member

evansims commented Sep 22, 2023

@Widcket 👋 Speaking with @poovamraj he indicated that we're going to backlog troubleshooting that Android smoke test for now. Do we need to update this PR to disable those, or how would you like to approach this PR?

@Widcket
Copy link
Contributor Author

Widcket commented Sep 22, 2023

I'll comment out that job.

@Widcket Widcket temporarily deployed to internal October 4, 2023 23:25 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal October 4, 2023 23:25 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal October 4, 2023 23:25 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal October 4, 2023 23:25 — with GitHub Actions Inactive
@Widcket
Copy link
Contributor Author

Widcket commented Oct 5, 2023

@evansims done, it's now ready for review.

@Widcket Widcket merged commit 88b7624 into main Oct 18, 2023
10 checks passed
@Widcket Widcket deleted the chore/github-actions branch October 18, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants