-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
af: Fix email verified type #309
Conversation
Hi @itome, thanks for raising this. Could you please expand on the circumstances where you found |
@Widcket I found it with apple login. Google login and Twitter login works correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @itome! Really appreciate the contribution.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
============================================
- Coverage 96.08% 95.80% -0.29%
============================================
Files 97 76 -21
Lines 1611 1121 -490
Branches 331 281 -50
============================================
- Hits 1548 1074 -474
+ Misses 49 46 -3
+ Partials 14 1 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itome the new test is failing:
@Widcket Sorry to be late. I fixed the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @itome!
This is now out in v1.3.1. |
email_verified
field is sometimesString
type instead ofbool
("true" instead of true).I'm not professional on OIDC so I don't know whether it's always
String
or bothString
andbool
is allowed.📋 Changes
Supoprt string type
email_verified
payload.📎 References
🎯 Testing