Add missing scope tags to connection options #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=======================================
Coverage 94.78% 94.79%
=======================================
Files 46 46
Lines 8733 8738 +5
=======================================
+ Hits 8278 8283 +5
Misses 353 353
Partials 102 102
☔ View full report in Codecov by Sentry. |
sergiught
commented
Aug 28, 2023
| @@ -861,6 +861,8 @@ type ConnectionOptionsAD struct { | |||
|
|
|||
| UpstreamParams map[string]interface{} `json:"upstream_params,omitempty"` | |||
|
|
|||
| Thumbprints *[]string `json:"thumbprints,omitempty"` | |||
There was a problem hiding this comment.
This also seems to have been missed from the AD connection options type.
There was a problem hiding this comment.
To note also that the SAML conn type has thumbprints defined as []interface{} instead.
There was a problem hiding this comment.
I think the SAML property was added before the schema repo so we didn't know the type of it?
ewanharris
approved these changes
Aug 29, 2023
Widcket
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Through https://github.com/auth0/go-auth0/pull/263/files we introduced the
ExtGroupsandExtProfileproperties on theConnectionOptionsPingFederateandConnectionOptionsSAML, however the scope tag was missed. This PR addresses that.To note also that unfortunately now we have inconsistent ways of describing the same attribute accepted by the API:
ext_groupsConnectionOptionsPingFederate.ExtGroupsConnectionOptionsSAML.ExtGroupsConnectionOptionsAzureAD.GroupsConnectionOptionsGoogleApps.Groupsext_profileConnectionOptionsPingFederate.ExtProfileConnectionOptionsSAML.ExtProfileConnectionOptionsGoogleApps.ExtendedProfileConnectionOptionsAzureAD.ExtendedProfile📚 References
🔬 Testing
📝 Checklist