Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line connection strategy #271

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Add line connection strategy #271

merged 2 commits into from
Aug 30, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Adding a line strategy constant to be able to support it within auth0/terraform-provider-auth0#785 as it's currently missing.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner August 30, 2023 10:41
@@ -205,6 +207,7 @@ func (c *Connection) UnmarshalJSON(b []byte) error {
ConnectionStrategyBox,
ConnectionStrategyWordpress,
ConnectionStrategyShopify,
ConnectionStrategyLine,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaulting it to Oauth2 options.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2075069) 94.79% compared to head (10a3d18) 94.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   94.79%   94.79%           
=======================================
  Files          46       46           
  Lines        8738     8738           
=======================================
  Hits         8283     8283           
  Misses        353      353           
  Partials      102      102           
Files Changed Coverage Δ
management/connection.go 75.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiught sergiught merged commit 29135bd into main Aug 30, 2023
4 checks passed
@sergiught sergiught deleted the feature/line-strategy branch August 30, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants