Merge pull request #604 from baulea/java17

ISSUE-598 # remove maven-compiler warnings with target Java 17 (JDK8 Compatible)
authorjapps · Mar 1, 2024 · d142ce3 · d142ce3
2 parents 61e8752 + a17bbb1
commit d142ce3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/core/src/main/java/org/jsmart/zerocode/core/kafka/helper/KafkaProducerHelper.java b/core/src/main/java/org/jsmart/zerocode/core/kafka/helper/KafkaProducerHelper.java
@@ -99,8 +99,8 @@ private static Object buildProtoMessage(String message, String requestJson) {
     private static Builder createBuilder(String messageClass) {
         try {
             Class<Message> msgClass = (Class<Message>) Class.forName(messageClass);
-            Method method = msgClass.getMethod("newBuilder", null);
-            return (Builder) method.invoke(null, null);
+            Method method = msgClass.getMethod("newBuilder", (Class<?>[]) null);
+            return (Builder) method.invoke(null, (Object[]) null);
         } catch (IllegalAccessException | ClassNotFoundException | NoSuchMethodException | SecurityException
                 | IllegalArgumentException | InvocationTargetException e) {
             throw new IllegalArgumentException(e);

diff --git a/core/src/test/java/org/jsmart/zerocode/core/engine/assertion/NumberComparatorTest.java b/core/src/test/java/org/jsmart/zerocode/core/engine/assertion/NumberComparatorTest.java
@@ -18,8 +18,8 @@ public void willCompareTwoDifferentNumbers_Rightly() throws Exception {
         assertThat((new BigDecimal("3.00009")).compareTo(new BigDecimal("3.00009")), is(0));
 
         NumberComparator comparator = new NumberComparator();
-        assertThat(comparator.compare(new Integer("3"), new Long("3")), is(0));
-        assertThat(comparator.compare(new Integer("3"), new Double("3.0")), is(0));
+        assertThat(comparator.compare(Integer.valueOf("3"), Long.valueOf("3")), is(0));
+        assertThat(comparator.compare(Integer.valueOf("3"), Double.valueOf("3.0")), is(0));
 
     }
 

diff --git a/...est/java/org/jsmart/zerocode/core/engine/executor/javaapi/JavaMethodExecutorImplTest.java b/...est/java/org/jsmart/zerocode/core/engine/executor/javaapi/JavaMethodExecutorImplTest.java
@@ -87,7 +87,7 @@ public void willExecuteJsonRequestForJavaMethod_noParam() throws Exception {
         String serviceName = scenarioSpec.getSteps().get(0).getUrl();
         String methodName = scenarioSpec.getSteps().get(0).getOperation();
 
-        Object result = methodExecutor.executeWithParams(serviceName, methodName, null);
+        Object result = methodExecutor.executeWithParams(serviceName, methodName, (Object[]) null);
 
         assertThat(result, is(30));
     }

diff --git a/core/src/test/java/org/jsmart/zerocode/core/runner/ZeroCodeUnitRuntimeAnnoTest.java b/core/src/test/java/org/jsmart/zerocode/core/runner/ZeroCodeUnitRuntimeAnnoTest.java
@@ -54,7 +54,7 @@ public void testScenario1() throws Exception {
 
     public static void alterAnnotation(Class<?> targetClass, Class<? extends Annotation> targetAnnotation, Annotation targetValue) {
         try {
-            Method method = Class.class.getDeclaredMethod(ANNOTATION_METHOD, null);
+            Method method = Class.class.getDeclaredMethod(ANNOTATION_METHOD, (Class<?>[]) null);
             method.setAccessible(true);
 
             Object annotationData = method.invoke(targetClass);