Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate dependency for protobuf-java in pom.xml #589

Closed
baulea opened this issue Oct 9, 2023 · 4 comments · Fixed by #590
Closed

Duplicate dependency for protobuf-java in pom.xml #589

baulea opened this issue Oct 9, 2023 · 4 comments · Fixed by #590

Comments

@baulea
Copy link
Contributor

baulea commented Oct 9, 2023

The dependency
<dependency> <groupId>com.google.protobuf</groupId> <artifactId>protobuf-java</artifactId> <version>${google.protobuf.version}</version> </dependency>
in the root pom.xml is duplicated. This causes a warning during maven build:

mvn clean install
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.jsmart:zerocode-tdd:jar:1.3.36-SNAPSHOT
[WARNING] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: com.google.protobuf:protobuf-java:jar -> duplicate declaration of version ${google.protobuf.version} @ org.jsmart:zerocode-tdd-parent:1.3.36-SNAPSHOT, /home/al/eclipse-workspace-zerocode/zerocode/pom.xml, line 276, column 16
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]

@Miffyyy-huahua
Copy link

hi, I think I can work on this issue, can you please assign it to me? thank you!

@authorjapps
Copy link
Owner

hi, I think I can work on this issue, can you please assign it to me? thank you!

done.

Thanks for picking this. 👍

Can you please raise the PR and paste the PR link here when ready?

@baulea
Copy link
Contributor Author

baulea commented Oct 10, 2023

I already sent the PR yesterday shortly after creating this issue: #590
Is there anything missing? I'm a newbie in open source workflows.

@Miffyyy-huahua
Copy link

I already sent the PR yesterday shortly after creating this issue: #590
Is there anything missing? I'm a newbie in open source workflows.

hi! I was working on this issue as well and I checked your code. We basically did the same thing and remove one duplicated dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants