Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-589 # Duplicate dependency for protobuf-java in pom.xml #590

Merged
merged 1 commit into from
Oct 11, 2023
Merged

ISSUE-589 # Duplicate dependency for protobuf-java in pom.xml #590

merged 1 commit into from
Oct 11, 2023

Conversation

baulea
Copy link
Contributor

@baulea baulea commented Oct 9, 2023

Duplicate dependency for protobuf-java in pom.xml removed

PR Branch
#ADD LINK TO THE PR BRANCH

Motivation and Context

Checklist:

  • Unit tests added

  • Integration tests added

  • Test names are meaningful

  • Feature manually tested

  • Branch build passed

  • No 'package.*' in the imports

  • Relevant Wiki page updated with clear instruction for the end user

    • Not applicable. This was only a refactor change, no functional or behaviour changes were introduced
  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

@nirmalchandra
Copy link
Collaborator

Hello @baulea , Can you check CI status here?
https://github.com/authorjapps/zerocode/pull/590/checks

Have a look,
If Passed, we should be ready to merge.
If Failed, please check the error and put a fix.

@baulea
Copy link
Contributor Author

baulea commented Oct 11, 2023

Hi @nirmalchandra, CI build status is successful:
build succeeded Oct 11, 2023 in 11m 19s

Thank you in advance for merging this PR.

@nirmalchandra nirmalchandra linked an issue Oct 11, 2023 that may be closed by this pull request
@nirmalchandra nirmalchandra merged commit 409ab72 into authorjapps:master Oct 11, 2023
1 check passed
@baulea baulea deleted the hotfix/protobuf-java branch October 15, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate dependency for protobuf-java in pom.xml
2 participants