Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-409 # Added support for csv file in the parameterized csvSource #474

Closed

Conversation

imprashant
Copy link
Collaborator

@imprashant imprashant commented Jan 23, 2021

Parameterized csvSource to fetch parameters from external csv file

Issue link

PR Branch
https://github.com/imprashant/zerocode/tree/409-csvsource-from-file

Support externalized csv files under Parameterized CSV source

This PR intends to address the problem mentioned in issue 409, to add support to fetch parameters from external csv source file.

Checklist:

  • Unit tests added

  • Integration tests added

  • Test names are meaningful

  • Feature manually tested

  • Branch build passed

  • No 'package.*' in the imports

  • Relevant Wiki page updated with clear instruction for the end user

    • Not applicable. This was only a refactor change, no functional or behaviour changes were introduced
  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

@imprashant
Copy link
Collaborator Author

@imprashant
Copy link
Collaborator Author

Build timing out : https://travis-ci.org/github/authorjapps/zerocode/builds/755814683

@authorjapps Sorry I do not have the rights to re-trigger the branch build, can some please re-trigger the build or please point me to a documentation as to how I can re-trigger the branch build, I suspect that the branch build failed due to timeout and might pass on rerun.

@authorjapps
Copy link
Owner

@imprashant , you are right, there is an issue out there. See the resolution page here.

Your collaboration invitation is here to accept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants