Maven dependencies #609
Maven dependencies #609
Conversation
Move maven plugin versions and configuration to <pluginManagement> section in parent.pom. Upgrade maven plugin versions. Fix warnings during maven build regarding missing version for maven-compiler-plugin [WARNING] [WARNING] Some problems were encountered while building the effective model for org.jsmart:http-testing:jar:1.3.36-SNAPSHOT [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 50, column 21 [WARNING] [WARNING] Some problems were encountered while building the effective model for org.jsmart:kafka-testing:jar:1.3.36-SNAPSHOT [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 56, column 12 [WARNING] [WARNING] Some problems were encountered while building the effective model for org.jsmart:zerocode-tdd-jupiter:jar:1.3.36-SNAPSHOT [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 145, column 21 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING]
upgrade dependencies in pom.xml: - upgrade org.jukito:jukito from 1.4.1 to 1.5 - upgrade commons-io:commons-io:2.4 to 2.15.0 - upgrade com.aventstack:extentreports:4.0.9 to 5.0.9 - upgrade com.google.code.gson:gson:2.6.2 to 2.10.1 - upgrade com.google.protobuf:protobuf-java:3.13.0 to 3.24.4 with upgrade com.aventstack:extentreports:4.0.9 to 5.0.9 replace ExtentHtmlReporter with ExtentSparkReporter in ExtentReportsFactory.java change in core/pom.xml: - set test scope for org.jukito:jukito - remove unused dependency com.fasterxml.jackson.datatype:jackson-datatype-jdk8 - remove direct dependency ch.qos.logback:logback-core, because it is a direct dependency from ch.qos.logback:logback-classic - add direct dependency org.apache.httpcomponents:httpmime:4.5.12 change in kafka-testing/pom.xml: - remove com.google.protobuf:protobuf-java-util - remove dependency for com.github.os72:protoc-jar
baulea
force-pushed
the
maven_dependencies
branch
from
7e60fd9 to
1633e74
Compare
|
Overall looking great @baulea . Any specific reason you updated from |
|
Thanks for the great work getting this PR raised. Was manually testing some aspects such as reports etc to ensure it's not breaking the existing projects. Will perform few more checks soon and then merge 👍 |
|
@nirmalchandra Thank you for reviewing the changes! I updated from ExtentHtmlReporter to ExtentSparkReporter, because ExtentHtmlReporter has been removed in version 5 of com.aventstack:extentreports https://stackoverflow.com/questions/66422304/extenthtmlreporter-class-cant-be-imported-with-extentreports-5-0-6-version |
|
@baulea Hey, do you think it is possible for us to a scan on the project to check if any other dependencies can be upgraded? One way to do this would be to analyze all the dependencies that have security vulnerabilities and corresponding fixes in a recent version. An IDE can be used to do this. On IntelliJ, when I I've attached a screenshot of analysis that I ran on your branch. Maybe we can use this as a reference |
@authorjapps Maybe we can merge this PR and then look into the other dependencies to be updated. What are your thoughts? |
|
This PR pretty much updates to latest versions of the most dependencies. |
Upgrade the libraries and make it compatible with Java8
PR Branch
here
Motivation and Context
upgrade multiple maven dependencies for later Java17 compatibility
#607
Checklist:
Unit tests added
Integration tests added
Test names are meaningful
Feature manually tested
Branch build passed
No 'package.*' in the imports
Relevant Wiki page updated with clear instruction for the end user
Http test added to
http-testingmodule(if applicable) ?Kafka test added to
kafka-testingmodule(if applicable) ?Manually tested the Reports generated and all tabs have visual metrics as earlier?