Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme toggle in HTML report #697

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

bppdanto-t
Copy link
Contributor

Add theme toggle in HTML report

Fixes Issue

PR Branch
https://github.com/bppdanto-t/zerocode/tree/add-theme-toggle

Motivation and Context

Due to version update of extentreport library, the toggle theme icon is missing from the HTML report. While toggling the theme is still achievable by pressing "L" key with keyboard, there's not much visibility to the user on how to do it. This PR will add the toggle icon back and move it to the top right side, as requested by @authorjapps (comment link).

Light theme
image

Dark theme
image

Checklist:

  • New Unit tests were added

    • Covered in existing Unit tests
  • Integration tests were added

    • Covered in existing Integration tests
  • Test names are meaningful

  • Feature manually tested and outcome is successful

  • PR doesn't break any of the earlier features for end users

    • WARNING! This might break one or more earlier earlier features, hence left a comment tagging all reviewrs
  • Branch build passed in CI

  • No 'package.*' in the imports

  • Relevant DOcumentation page added or updated with clear instructions and examples for the end user

    • Not applicable. This was only a code refactor change, no functional or behaviourial changes were introduced
  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

@authorjapps
Copy link
Owner

Tested locally.
Looking great.
Amazing work mate, thanks for sorting this out.

@authorjapps authorjapps merged commit c86bb83 into authorjapps:master Nov 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants