pkg/proto: adopt CodecV2 and gRPC buffer pooling #2070
+96
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat15
reviewed
Sep 18, 2024
| pool.Put(buf) | ||
| return nil, err | ||
| } | ||
| return mem.BufferSlice{mem.NewBuffer(buf, pool)}, nil |
There was a problem hiding this comment.
Curious - what does NewBuffer do here? Haven't we already reserved the relevant memory in the pool.Get call above?
Alternatively, is there some reading about how this approach works generally?
There was a problem hiding this comment.
By and large, this code is inspired by the upstream default codec: https://github.com/grpc/grpc-go/blob/v1.66.2/encoding/proto/proto.go
mem.NewBuffer is less about allocating bytes and more about tracking the lifetime and ownership of the buffer: https://github.com/grpc/grpc-go/blob/v1.66.2/mem/buffers.go#L83-L102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces our existing gRPC codec (which enabled us to use vtprotobuf) with the new v2 codec interface that can support buffer pooling.
Huge thanks to engineers from Google and LinkedIn for fleshing out this work and upstreaming the necessary changes. There was a great talk from gRPConf I can share once it's uploaded to YouTube.
I did regenerate our go.mod which combined all of the indirect dependencies into one block. If there were purposely split out, I can fix it.
See the sister PR to this introducing the Codec for Vitess: vitessio/vitess#16790