reduce build times in CI #2085
Merged
reduce build times in CI #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/schema
vroldanbet
force-pushed
the
make-unit-tests-faster
branch
3 times, most recently
from
3ec25a8
to
b369aa2
Compare
vroldanbet
force-pushed
the
make-unit-tests-faster
branch
3 times, most recently
from
2560b66
to
642c5af
Compare
by enabling parallel tests. Made unit tests run 30% faster Also added some parallelism to Datastore tests, but opt-in. MemDB and datastore proxy tests are now parallel. Also changed CRDB test entry points to run in parallel, since the introduction of integrity tests meant double the tests to run, and sequentially
vroldanbet
force-pushed
the
make-unit-tests-faster
branch
from
642c5af
to
b47ef2c
Compare
tstirrat15
reviewed
Oct 2, 2024
| @@ -30,7 +29,7 @@ import ( | |||
| var ONR = tuple.ObjectAndRelation | |||
|
|
|||
| func TestSimpleCheck(t *testing.T) { | |||
| defer goleak.VerifyNone(t, append(testutil.GoLeakIgnores(), goleak.IgnoreCurrent())...) | |||
There was a problem hiding this comment.
Was this no longer necessary?
There was a problem hiding this comment.
no - it's moved into a TestMain function which makes it execute for all tests in the package
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimized tests with various changes. 40% improvement in CI in some cases.
t.Parallel()in the unit tests taking the longestbefore
after