Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to tuple helpers #2107

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Updates to tuple helpers #2107

merged 3 commits into from
Oct 30, 2024

Conversation

tstirrat15
Copy link
Contributor

Description

Came up the context of authzed/zed#431. The lack of context in the string helper isn't clear from the name, and having a MustParseV1 function makes writing tests in zed and elsewhere easier.

Changes

  • Rename fn
  • Update usage
  • Add new helper for tests

Testing

Review.

@tstirrat15 tstirrat15 marked this pull request as ready for review October 30, 2024 18:01
@tstirrat15 tstirrat15 requested a review from a team as a code owner October 30, 2024 18:01
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tstirrat15 tstirrat15 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 11d23ae Oct 30, 2024
22 checks passed
@tstirrat15 tstirrat15 deleted the updates-to-tuple-helpers branch October 30, 2024 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants