Add a new consistency middleware for full-consistency-only callers #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a service label onto the metrics generated to allow for disambiguation where SpiceDB might be embedded
github-actions
bot
added
area/CLI
alecmerdler
reviewed
Oct 30, 2024
| ConsistentyCounter.WithLabelValues("minlatency", source).Inc() | ||
|
|
||
| if serviceLabel != "" { | ||
| ConsistentyCounter.WithLabelValues("minlatency", source, serviceLabel).Inc() |
alecmerdler
reviewed
Oct 30, 2024
| // ForceFullConsistencyUnaryServerInterceptor returns a new unary server interceptor that enforces full consistency | ||
| // for all requests, except for those in the bypassServiceWhitelist. | ||
| func ForceFullConsistencyUnaryServerInterceptor(serviceLabel string) grpc.UnaryServerInterceptor { | ||
| return func(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) { |
There was a problem hiding this comment.
nit: use any instead of interface{}
alecmerdler
approved these changes
Oct 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a service label onto the metrics generated to allow for disambiguation where SpiceDB might be embedded