Fix MySQL test breakage caused by daylight savings change #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/datastore
Seriously, it broke due to the DST change because it just *happen* to match the -5 hours window used for the test. The fix is to move the test that changes the instance's timezone to its own, isolated, MySQL so it doesn't interfere with the other tests
josephschorr
force-pushed
the
fix-mysql-tests
branch
from
032e9a1
to
13e08a9
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seriously, it broke due to the DST change because it just happen to match the -5 hours window used for the test.
The fix is to move the test that changes the instance's timezone to its own, isolated, MySQL so it doesn't interfere with the other tests