support canceling long-running backup/restore operations #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
force-pushed
the
support-canceling-bulk-load
branch
3 times, most recently
from
b436fb3 to
6ec8662
Compare
vroldanbet
force-pushed
the
support-canceling-bulk-load
branch
from
6ec8662 to
4847521
Compare
jzelinskie
approved these changes
Nov 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
restoreandbackupcommands can take long depending on the number of relationships. I found myself trying to abort some instances of those command andzedwouldn't react toControl+C. The reason was that context cancelation wasn't being checked.With this change the operation will abort immediately ⚡