[DNM] SAML Authentication #1593
Draft
+98
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…system: * don't assume we have github ssh key installed - this would make sense on a dev system but not for a production system * make is not necessarily already installed * in recent versions of docker, "docker compose" (via docker-compose-plugin) is used instead of "docker-compose" * sudo is not necessarily installed, and should not be required
…was the only way I could find to get SAML auth to work. I would very much prefer another solution or workaround.
…will need to enable SAML authentication for autolab. The "Enterprise Applications" admin will need to provide the fingerprint and target URL/entity ID specific to your site. (They may call this "metadata")
|
Apart from the CSRF thing, the most significant problem I see here is that you are embedding microsoft's (OASIS WS-Security) attribute mappings, which are not the same as the ones used by IdPs in the incommon federation. The attribute uris need to be configurable by the end institution, and there should be some exception handling or other validation. it may make sense to start parameterizing the LDAP lookups too and remove the embedded fixed domain (andrew.cmu.edu) |
damianhxy
commented
Nov 11, 2022
| @@ -60,6 +60,8 @@ gem 'omniauth', '>=1.2.2' | |||
| gem 'omniauth-facebook', '>=2.0.0' | |||
| gem 'omniauth-google-oauth2', '>=0.2.5' | |||
| gem 'omniauth-shibboleth', '>=1.1.2' | |||
| gem 'omniauth-saml', '>=1.7.0' | |||
| gem 'omniauth-rails_csrf_protection' | |||
There was a problem hiding this comment.
Should be unnecessary with omniauth v2.0.0
damianhxy
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Add SAML authentication to Autolab for universities that use Microsoft IdP.
Note:
verify_authenticity_token). Ideally, we should be usingaction_no_authto selectively disable the protection for routes that do not require authenticationGemfile.lockHow Has This Been Tested?
Types of changes
Checklist:
overcommit --install && overcommit --signto use pre-commit hook for linting