Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New model spec metadata format with runtime and model resource information #268

Merged
merged 9 commits into from
Aug 27, 2023

Conversation

spillai
Copy link
Contributor

@spillai spillai commented Jul 31, 2023

Summary

  • rename remote() to __call__() to keep API consistent with models
  • added tests for batched execution with new ModelHandle.submit() API
  • added tests for ModelHandle.scale() with multiple replicas
  • Load nos model specification from profile
  • Fix test_model_manager_errors that does not raise error any more with num_replicas>1
  • Updated model manager tests for various image-based tasks

Related issues

Checks

  • make lint: I've run make lint to lint the changes in this PR.
  • make test: I've made sure the tests (make test-cpu or make test) are passing.
  • Additional tests:
    • Benchmark tests (when contributing new models)
    • GPU/HW tests

@spillai spillai self-assigned this Jul 31, 2023
@spillai spillai force-pushed the spillai/profiled-model-spec branch from 278de48 to 5daf1a2 Compare August 22, 2023 21:21
@spillai spillai added this to the NOS v0.0.10 milestone Aug 23, 2023
@spillai spillai force-pushed the spillai/profiled-model-spec branch from 5daf1a2 to f4f07a1 Compare August 27, 2023 21:14
@spillai spillai force-pushed the spillai/profiled-model-spec branch from f4f07a1 to 3f01c66 Compare August 27, 2023 23:41
@spillai spillai changed the title [DNM] New model spec metadata format with runtime and model resource information New model spec metadata format with runtime and model resource information Aug 27, 2023
@spillai spillai merged commit 058e243 into main Aug 27, 2023
1 check passed
@spillai spillai deleted the spillai/profiled-model-spec branch September 5, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant