Set up nos bot to save training images #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run bot inside a discord server alongside nos Kick off a training job on saved images
spillai
reviewed
Aug 29, 2023
nos/experimental/discord/nos_bot.py
Outdated
| "name": "sdv21-dreambooth-lora-test-bench", | ||
| }, | ||
| ) | ||
| assert job_id is not None |
There was a problem hiding this comment.
raise an error so that the discord bot user gets some internal server error
spillai
reviewed
Aug 29, 2023
nos/experimental/discord/nos_bot.py
Outdated
| # Kick off a nos training run | ||
| from nos.server._service import TrainingService | ||
|
|
||
| svc = TrainingService() |
There was a problem hiding this comment.
Move this to top of file, no need to instantiate it every time we run training
spillai
reviewed
Aug 29, 2023
nos/experimental/discord/nos_bot.py
Outdated
| await thread.send(f"Image {attachment.filename} saved!") | ||
|
|
||
| # Kick off a nos training run | ||
| from nos.server._service import TrainingService |
spillai
reviewed
Aug 29, 2023
nos/experimental/discord/nos_bot.py
Outdated
|
|
||
| # save the attachments | ||
| for attachment in ctx.message.attachments: | ||
| print(f"got attachement: {attachment.filename}") |
spillai
reviewed
Aug 29, 2023
nos/experimental/discord/nos_bot.py
Outdated
| return | ||
|
|
||
| if not ctx.message.attachments: | ||
| print("no attachments to train on, returning!") |
spillai
reviewed
Aug 29, 2023
nos/experimental/discord/nos_bot.py
Outdated
| dirname = NOS_TRAINING_DIR / thread_name | ||
| dirname.mkdir(parents=True, exist_ok=True) | ||
|
|
||
| await thread.send("saving at dir: " + str(dirname)) |
There was a problem hiding this comment.
nit Use fstrings as much as possible `send(f"saving at dir: {dirname}")
spillai
reviewed
Aug 29, 2023
nos/experimental/discord/nos_bot.py
Outdated
| # save the attachments | ||
| for attachment in ctx.message.attachments: | ||
| print(f"got attachement: {attachment.filename}") | ||
| await attachment.save(os.path.join(dirname, attachment.filename)) |
There was a problem hiding this comment.
Use Pathlib operators instead dirname / attachment.filename
spillai
reviewed
Aug 29, 2023
nos/experimental/discord/nos_bot.py
Outdated
| @@ -24,9 +24,13 @@ | |||
| # Create our bot: | |||
| bot = commands.Bot(command_prefix="$", intents=intents) | |||
|
|
|||
| TRAINING_CHANNEL_NAME = "training" | |||
spillai
reviewed
Aug 29, 2023
nos/experimental/discord/nos_bot.py
Outdated
| @@ -24,9 +24,13 @@ | |||
| # Create our bot: | |||
| bot = commands.Bot(command_prefix="$", intents=intents) | |||
|
|
|||
| TRAINING_CHANNEL_NAME = "training" | |||
| NOS_TRAINING_DIR = NOS_TMP_DIR / "train" | |||
There was a problem hiding this comment.
NOS_TMP_DIR / "discord/{CHANNEL_NAME}/train"
spillai
reviewed
Aug 29, 2023
| @@ -113,3 +113,6 @@ docker-compose-upd-cpu: docker-build-cpu | |||
|
|
|||
| docker-compose-upd-gpu: docker-build-gpu | |||
| docker compose -f docker-compose.gpu.yml up | |||
|
|
|||
| docker-compose-upd-discord-bot: docker-build-gpu | |||
There was a problem hiding this comment.
Move this to a standalone Makefile under examples/discord
|
Merged in #314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To start the server:
./nos/experimental/discord/nos_bot.pyTo run image generation:
$generate promptTo kick off a training job:
$trainA thread will be created including the training image directory.
Checks
make lint: I've runmake lintto lint the changes in this PR.make test: I've made sure the tests (make test-cpuormake test) are passing.Checks
make lint: I've runmake lintto lint the changes in this PR.make test: I've made sure the tests (make test-cpuormake test) are passing.