Cleanup client-side integrations and tests #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated entrypoint to support both gRPC and HTTP serving - Updated default gRPC host to localhost to avoid ipv6 issues within docker - Updated docker-compose files to support single-container gRPC serving + HTTP proxy - Updated default `nos.client.Client()` address to use `localhost:50051` for gRPC and avoid having to manually set for examples.
spillai
force-pushed
the
spillai/0.2.1-dev
branch
from
0ec6504
to
d43307e
Compare
spillai
force-pushed
the
spillai/0.2.1-dev
branch
from
d43307e
to
761036a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nosmodule level imports and trimmed client-side integrationsRelated issues
Checks
make lint: I've runmake lintto lint the changes in this PR.make test: I've made sure the tests (make test-cpuormake test) are passing.