-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FL_Studio Recipes to new Major Version #99
Conversation
Adds in a step to grab the `minimum_os_version` from the vendors website. ``` autopkg run -v FLStudio.munki.recipe Looking for com.github.apizz.pkg.FLStudio... Did not find com.github.apizz.pkg.FLStudio in recipe map Rebuilding recipe map with current working directories... Looking for com.github.apizz.pkg.FLStudio... Found com.github.apizz.pkg.FLStudio in recipe map Looking for com.github.apizz.download.FLStudio... Found com.github.apizz.download.FLStudio in recipe map **load_recipe time: 0.007654834000277333 Processing FLStudio.munki.recipe... WARNING: FLStudio.munki.recipe is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding... URLDownloader URLDownloader: Storing new Last-Modified header: Fri, 05 Jul 2024 03:01:18 GMT URLDownloader: Storing new ETag header: "c4a2dac3a1a56866a914167a7619621c" URLDownloader: Downloaded /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/downloads/FLStudio.dmg EndOfCheckPhase FileFinder FileFinder: Mounted disk image /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/downloads/FLStudio.dmg FileFinder: Found file match: '/private/tmp/dmg.wYgZu8/Install FL Studio.pkg' from globbed '/private/tmp/dmg.wYgZu8/Install*.pkg' FileFinder: DMG-relative file match: 'Install FL Studio.pkg' FileFinder: Basename match: 'Install FL Studio.pkg' CodeSignatureVerifier CodeSignatureVerifier: Mounted disk image /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/downloads/FLStudio.dmg CodeSignatureVerifier: Verifying installer package signature... CodeSignatureVerifier: Package "Install FL Studio.pkg": CodeSignatureVerifier: Status: signed by a developer certificate issued by Apple for distribution CodeSignatureVerifier: Notarization: trusted by the Apple notary service CodeSignatureVerifier: Signed with a trusted timestamp on: 2024-07-03 16:45:13 +0000 CodeSignatureVerifier: Certificate Chain: CodeSignatureVerifier: 1. Developer ID Installer: image-line (N68WEP5ZZZ) CodeSignatureVerifier: Expires: 2027-10-25 13:05:28 +0000 CodeSignatureVerifier: SHA256 Fingerprint: CodeSignatureVerifier: BD A3 8F E5 68 44 35 97 24 4A 45 94 5C 68 7A B2 DB F7 E0 10 D0 1B CodeSignatureVerifier: 84 C5 F2 87 C7 7D 13 E5 62 52 CodeSignatureVerifier: ------------------------------------------------------------------------ CodeSignatureVerifier: 2. Developer ID Certification Authority CodeSignatureVerifier: Expires: 2031-09-17 00:00:00 +0000 CodeSignatureVerifier: SHA256 Fingerprint: CodeSignatureVerifier: F1 6C D3 C5 4C 7F 83 CE A4 BF 1A 3E 6A 08 19 C8 AA A8 E4 A1 52 8F CodeSignatureVerifier: D1 44 71 5F 35 06 43 D2 DF 3A CodeSignatureVerifier: ------------------------------------------------------------------------ CodeSignatureVerifier: 3. Apple Root CA CodeSignatureVerifier: Expires: 2035-02-09 21:40:36 +0000 CodeSignatureVerifier: SHA256 Fingerprint: CodeSignatureVerifier: B0 B1 73 0E CB C7 FF 45 05 14 2C 49 F1 29 5E 6E DA 6B CA ED 7E 2C CodeSignatureVerifier: 68 C5 BE 91 B5 A1 10 01 F0 24 CodeSignatureVerifier: CodeSignatureVerifier: Signature is valid CodeSignatureVerifier: Authority name chain is valid FlatPkgUnpacker FlatPkgUnpacker: Mounted disk image /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/downloads/FLStudio.dmg FlatPkgUnpacker: Unpacked /private/tmp/dmg.X2olxQ/Install FL Studio.pkg to /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/unpack PkgPayloadUnpacker PkgPayloadUnpacker: Unpacked /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/unpack/FL_Studio.pkg/Payload to /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/FLStudio PlistReader PlistReader: Reading: /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/FLStudio/Applications/FL Studio 2024.app/Contents/Info.plist PlistReader: Assigning value of '24.1.1.3884' to output variable 'version' PkgCopier PkgCopier: Mounted disk image /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/downloads/FLStudio.dmg PkgCopier: Copied /private/tmp/dmg.RkSzxw/Install FL Studio.pkg to /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/FLStudio.pkg MunkiInstallsItemsCreator MunkiInstallsItemsCreator: Created installs item for /Applications/FL Studio 2024.app MunkiPkginfoMerger MunkiPkginfoMerger: Merged {'installs': [{'CFBundleIdentifier': 'com.image-line.flstudio', 'CFBundleName': 'FL Studio', 'CFBundleShortVersionString': '24.1.1.3884', 'CFBundleVersion': '24.1.1.3884', 'path': '/Applications/FL Studio 2024.app', 'type': 'application', 'version_comparison_key': 'CFBundleShortVersionString'}]} into pkginfo URLTextSearcher URLTextSearcher: Found matching text (min_os_ver): 10.15 MunkiPkginfoMerger MunkiPkginfoMerger: Merged {'version': '24.1.1.3884', 'minimum_os_version': '10.15'} into pkginfo MunkiImporter MunkiImporter: Using repo lib: AutoPkgLib MunkiImporter: plugin: FileRepo MunkiImporter: repo: /Users/Shared/munki_repo MunkiImporter: Copied pkginfo to: /Users/Shared/munki_repo/pkgsinfo/apps/flstudio/FLStudio-24.1.1.3884__1.plist MunkiImporter: pkg to: /Users/Shared/munki_repo/pkgs/apps/flstudio/FLStudio-24.1.1.3884__1.pkg com.github.grahampugh.recipes.commonprocessors/ChangeModeOwner PathDeleter PathDeleter: Deleted /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/unpack PathDeleter: Deleted /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/FLStudio/Applications/FL Studio 2024.app PathDeleter: Deleted /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/FLStudio/Applications PathDeleter: Deleted /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/FLStudio Receipt written to /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/receipts/FLStudio.munki-receipt-20240709-142747.plist The following new items were downloaded: Download Path ------------- /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/downloads/FLStudio.dmg The following packages were copied: Pkg Path -------- /Users/paul.cossey/Library/AutoPkg/Cache/com.github.apizz.munki.FLStudio/FLStudio.pkg The following new items were imported into Munki: Name Version Catalogs Pkginfo Path Pkg Repo Path Icon Repo Path ---- ------- -------- ------------ ------------- -------------- FLStudio 24.1.1.3884 testing apps/flstudio/FLStudio-24.1.1.3884__1.plist apps/flstudio/FLStudio-24.1.1.3884__1.pkg ```
Switches to using an uninstall script as removepackages doesn't remove everything.
<string>%RECIPE_CACHE_DIR%/%NAME%</string> | ||
</dict> | ||
<key>Processor</key> | ||
<string>com.github.grahampugh.recipes.commonprocessors/ChangeModeOwner</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no interest in including a non-standard autopkg processor as a requirement in the recipe flow when it's not necessary to do so.
Please use one of the standard processors (like PkgRootCreator) which is sufficient for creating a directory with a desired set of permissions.
I appreciate your stance, but I don't think a standard processor will have the required effect. The problem with
I can't really do any testing or make additional changes as the vendor has added some CloudFlare protections that require human interaction. Last time I saw this, it was removed after a few weeks. But this could be a permanent change.
|
The CloudFlare Block seems to have gone now, but, I'll close this, we're happy to have non-standard processors in our repo I've added our own recipes for FL Studio 2024: https://github.com/autopkg/dataJAR-recipes/tree/master/FL%20Studio%202024 |
Hi, @apizz
FL Studio 21 is now FL Studio 2024. This PR updated the download and Munki recipes to reflect the changes.
I kept running in to
[Errno 66] Directory not empty:
with PathDeleter to get around the issue, I've added in ChangeModeOwner processor and some extra PathDeleter steps.Output from a successful -vv run