refactor(factor): move steering factor interface to motion utils #9337
+16
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
github-actions
bot
added
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
satoshi-ota
requested review from
danielsanchezaran,
rej55,
go-sakayori,
kosuke55,
soblin,
maxime-clem,
shmpwk,
TakaHoribe,
takayuki5168,
tkimura4,
zulfaqar-azmi-t4,
kyoichi-sugahara,
TomohitoAndo and
taikitanaka3
as code owners
soblin
approved these changes
Nov 15, 2024
satoshi-ota
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9337 +/- ##
=======================================
Coverage 29.81% 29.81%
=======================================
Files 1338 1339 +1
Lines 103200 103220 +20
Branches 40208 40209 +1
=======================================
+ Hits 30774 30780 +6
- Misses 69437 69452 +15
+ Partials 2989 2988 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move steering factor interface to
autoware_motion_utilsfrom bpp package so that the other modules can use it.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.