Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bpp): add velocity interface #9344

Merged
merged 2 commits into from
Nov 18, 2024
Merged

feat(bpp): add velocity interface #9344

merged 2 commits into from
Nov 18, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 18, 2024 •
edited
Loading

Description

Some of behavior path planner modules inserts stop points but no one outputs velocity factor.

In this PR, I added interface to publish velocity factor topic.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@satoshi-ota
feat(bpp): add velocity interface
1aafa2d 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(adapi): subscribe additional velocity factors
40d43a8 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Nov 18, 2024
@github-actions GitHub Actions
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@satoshi-ota satoshi-ota marked this pull request as ready for review November 18, 2024 00:13
go-sakayori
go-sakayori approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@go-sakayori go-sakayori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 18, 2024
zulfaqar-azmi-t4
zulfaqar-azmi-t4 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 29.80%. Comparing base (6f40830) to head (40d43a8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ommon/interface/scene_module_manager_interface.hpp 33.33% 5 Missing and 1 partial ⚠️
...lanner_common/interface/scene_module_interface.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9344      +/-   ##
==========================================
- Coverage   29.81%   29.80%   -0.01%     
==========================================
  Files        1338     1342       +4     
  Lines      103205   103256      +51     
  Branches    40210    40217       +7     
==========================================
+ Hits        30771    30778       +7     
- Misses      69447    69490      +43     
- Partials     2987     2988       +1
Flag Coverage Δ *Carryforward flag
differential 19.82% <46.15%> (?)
total 29.81% <ø> (-0.01%) ⬇️ Carriedforward from 08951b2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 93828b6 into autowarefoundation:main Nov 18, 2024
41 of 42 checks passed
@satoshi-ota satoshi-ota deleted the feat/bpp-velocity-factor branch November 18, 2024 01:29
This was referenced Nov 18, 2024
Merged
Merged
This was referenced Nov 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 zulfaqar-azmi-t4 approved these changes

@go-sakayori go-sakayori go-sakayori approved these changes

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi isamu-takagi is a code owner

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r mitsudome-r is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran danielsanchezaran is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@maxime-clem maxime-clem Awaiting requested review from maxime-clem maxime-clem is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satoshi-ota @go-sakayori @zulfaqar-azmi-t4