This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
fix: boost optional build error on rolling environment #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: f0reachARR <f0reach@f0reach.me>
f0reachARR
force-pushed
the
fix-boost-optional-error
branch
from
d985235
to
e3311b0
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. |
f0reachARR
requested review from
kosuke55,
soblin,
Motsu-san,
mitsudome-r and
takayuki5168
as code owners
soblin
approved these changes
May 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As ROS 2 jazzy will be released soon, this PR will fix build error found in rolling build environment.
boost/optional/optional_io.hppto some source files. This header file is required by newer version of Boost.Tests performed
colcon teston humble distribution does not show new error.Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.