Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rpc-providers.md #1772

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Update rpc-providers.md #1772

merged 5 commits into from
Jun 11, 2024

Conversation

yunseonna
Copy link
Contributor

Proposing to update additional possible public RPC endpoint powered by All That Node.

Docs PR Template

Why this should be merged

Proposing to update additional possible public RPC endpoint powered by All That Node.

How this works

Just endpoints and links about new features

How these changes were tested

To prevent any errors while building

  • [] run vale /docs/file/path on all changed .md files to ensure all grammar rules pass
  • [] run markdownlint /docs/file/path on all changed .md files to ensure all linting rules pass
  • [] complete the above two checks and all additional rules outlined in style-checker-notes.md to
    ensure all checks pass

If a document was removed/deleted

  • [] the path to that doc must be redirected to a valid URL via the
    _redirects file
  • [] _redirects were manually verified with the cloudflare preview link
  • [] sidebars.json reflects all changes made to file path

If a document was moved

  • [] all files that were moved from their current directory to a new path have had their paths
    redirected via the _redirects file
  • [] _redirects were manually verified with the cloudflare preview link
  • [] sidebars.json reflects all changes made to file path

Proposing to update additional possible public RPC endpoint powered by All That Node.

Signed-off-by: yunseon na <148749864+yunseonna@users.noreply.github.com>
@laviniat1996
Copy link
Contributor

@yunseonna Hi, can you please address the failed checks?

@yunseonna
Copy link
Contributor Author

@laviniat1996
I received the following error: "Error: reviewdog exited with status code: 1." in the Cl/ runner/vale (pull_request) .

Could you explain why it failed and how I can fix it?

@laviniat1996
Copy link
Contributor

@yunseonna the vale checker just didn't like some words, so I turned it off for some lines. All checks pass now, so merging this! thank you for contributing

@laviniat1996 laviniat1996 merged commit 3036346 into ava-labs:master Jun 11, 2024
4 checks passed
@yunseonna
Copy link
Contributor Author

Hi @laviniat1996

Thank you for your responses. I just noticed that the service name is incorrectly entered. Could you please change it from "All That Nodes" to "All That Node"?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants