Support arbitrary contract calls #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoriver
changed the title
cryptoriver
commented
Sep 25, 2023
cryptoriver
commented
Sep 25, 2023
ceyonur
reviewed
Oct 4, 2023
cryptoriver
force-pushed
the
contract_call_support
branch
from
dd7b706 to
3fa3b4a
Compare
xiaoxiaff
reviewed
Oct 11, 2023
patrick-ogrady
changed the base branch from
master
to
arbitrary-contract-calls
patrick-ogrady
merged commit 9b3519c
into
ava-labs:arbitrary-contract-calls
2 of 3 checks passed
patrick-ogrady
added a commit
that referenced
this pull request
Oct 23, 2023
* Support arbitrary contract calls (#223) * support generic contract calls * support test on arm64 * address pr comments * address pr comments * panic if type conversion fails * address pr comments * fix * fix checking generic contract call method * fix docker build * define consts at top of file * cleanup construction checks * add link to type source * fix linting errors * add comment explaining how generic check works * add more comments --------- Co-authored-by: cryptoriver <114266151+cryptoriver@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pr enables arbitrary contract call support in avalanche rosetta implementation by introducing a utility function
constructContractCallDataGenericfor encoding data field for any contract call method and its arguments.Other than that, we updated the handlers of these endpoints to enable producing/carrying contract call data.
Note: If argument list contains tuple, the client side must provide the encoded ABI data as the only argument in the argument list because encoding tuple type in this rosetta implementation is not yet supported.
Test
regression test